Skip to content
This repository was archived by the owner on Nov 18, 2024. It is now read-only.

Conversation

@bobmatyas
Copy link
Contributor

Description

Per #346, this adds the text-wrap style to deal with widows and orphans.

Screenshots

Before Example:

before-text-wrap

After Example:

after-text-wrap

Testing Instructions

@github-actions
Copy link

github-actions bot commented Sep 17, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: bobmatyas <[email protected]>
Co-authored-by: ryelle <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: beafialho <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@luminuu luminuu linked an issue Sep 17, 2024 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Sep 18, 2024

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@bobmatyas bobmatyas force-pushed the trunk branch 3 times, most recently from daed7a4 to 9704ff9 Compare September 18, 2024 17:43
@bobmatyas bobmatyas requested a review from ryelle September 18, 2024 17:45
Copy link
Contributor

@carolinan carolinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, please remove changes that are unrelated to the text-wrap.

@bobmatyas
Copy link
Contributor Author

@carolinan I think I was able to remove the extraneous commits. 🤞

Co-authored-by: Carolina Nymark <[email protected]>
@carolinan
Copy link
Contributor

This style is only enqueued on the front, and I think this is the right decision.
Without extensive testing, we won't know if there would be any negative impacts on the interface if the style would be added to the editor. Some parts of the editor already use text-wrap on these elements.

@carolinan carolinan merged commit f4d66f2 into WordPress:trunk Sep 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhancement to reduce widows and orphans in the theme

3 participants