The buttons especially in noon are still problematic, with some background colors both the default and outline buttons look like plain text.

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: beafialho <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: jasmussen <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

From the screenshot, it looks like section 3 and 5 in afternoon is the same?

The button outlines in styles 2 and 4 don't look good in any of the variations. Is there something we can do about it?

I'll try to add a different color in Afternoon.

The button outlines in styles 2 and 4 don't look good in any of the variations. Is there something we can do about it?

I think this will be the most difficult part about adding the variations.

In styles/blocks/section-2.json the button is set to contrast and base:

"elements": {
			"button": {
				"color": {
					"background": "var:preset|color|contrast",
					"text": "var:preset|color|base"
				}
			}

Then in noon (as an example), section-2 can be updated like this:

"variations": {
		"section-2": {
				"elements": {
					"button": {
						"color": {
							"background": "anything",
							"text": "anything"
						}
					}
...

(the outline button can not be changed the same way)

Preview changes

You can preview these changes by following the link below:

• Preview changes for twentytwentyfive

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

The button outlines in styles 2 and 4 don't look good in any of the variations. Is there something we can do about it?

Yes the colors can be changed. And I mean I can implement it and I could make a decision about what colors to use but you might not like it 🥹
So basically I need to know what it is supposed to look like.

For evening, I believe section one is supposed to have buttons with black background:

And section two buttons should have a dark purple background:

Section 3 should have the white buttons that they do in this PR, but after that, I don't know because the styles are not in Figma.

Here is the list of color changes that were made: I would like to know if the color palette presets should be updated to match the changes in the global style variation.

Noon

Evening

Overall, looks good! Saw no issues with the styles other than what Carolina has mentioned.

What @richtabor mentioned about style variations is still on my mind for this one: is it simply echoing the changes you are already proposing here, @carolinan?

Essentially what we want to avoid is having style variations that have color or font palettes that are unique from the discrete color and font presets, these:

If we can keep those in sync, we can move fast. Otherwise we should get the presets perfected first, and then combine them into variations. What do you think?

Note, I was AFK for a bit and catching up, so apologies if I'm missing a nuance, and thank you for the pings!

Yes, that was my intention, for the palette color and the global style variations to match. It is not clear to me why the palettes needed to change.

I believe it would be easier to manage these as separate pull requests.

In afternoon, section 5 is drastically different when comparing the pull request and Figma, so I have not touched it.