Skip to content
This repository was archived by the owner on Nov 18, 2024. It is now read-only.

Conversation

@beafialho
Copy link
Contributor

@beafialho beafialho commented Sep 11, 2024

Description

Currently, the default blog templates have local customisations to the headings font sizes, and blocks like Query Title in archive, search results have specific font size presets set globally as well. With the recent heading sizes adjustments in #231, these local customisations are no longer necessary and actually make the templates look worse. So I went ahead and made the following changes:

  • Removed local font size preset from the Title in the single.html
  • Removed local font size preset from the Title in the page.html
  • Removed local font size preset from Query Title in theme.json
  • Removed local font size preset set to H1 in index.html
  • Removed local font size preset from H1 in hidden-404.php

Screenshots

Here's what I mean, notice how it's much more comfortable to read the post title. And it's also more approximate to the Figma's original intention.

Before After
Captura de ecrã 2024-09-11, às 15 28 51 Captura de ecrã 2024-09-11, às 15 28 39

@github-actions
Copy link

github-actions bot commented Sep 11, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: beafialho <[email protected]>
Co-authored-by: juanfra <[email protected]>
Co-authored-by: jasmussen <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@jasmussen
Copy link
Contributor

Looks good!

@juanfra juanfra added the [Type] Enhancement A suggestion for improvement. label Sep 11, 2024
Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

@carolinan carolinan merged commit a9581b9 into trunk Sep 12, 2024
@juanfra juanfra deleted the visual-adjustments-default-templates-styles branch September 12, 2024 09:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

[Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants