Skip to content
This repository was archived by the owner on Nov 18, 2024. It is now read-only.

Added comments to all single templates#266

Closed
eirichmond wants to merge 4 commits intoWordPress:trunkfrom
eirichmond:try/single-templates-comments
Closed

Added comments to all single templates#266
eirichmond wants to merge 4 commits intoWordPress:trunkfrom
eirichmond:try/single-templates-comments

Conversation

@eirichmond
Copy link
Contributor

Description

To add comments to "single" templates

Screenshots

Screen.Recording.2024-09-10.at.4.34.55.PM.mov

Testing Instructions

Got to Site Editor
Select Single Post template
To view comments select Design for:

News blog single post with sidebar.
Photo blog single post.
Text only blog single post.
Right aligned single post.

@github-actions
Copy link

github-actions bot commented Sep 10, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: eirichmond <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: juanfra <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@carolinan
Copy link
Contributor

Please see the comment on #257.

The templates need to reuse the existing pattern for the comments, to reduce the maintenance burden of needing to update the same code in multiple places.

@eirichmond
Copy link
Contributor Author

Please see the comment on #257.

The templates need to reuse the existing pattern for the comments, to reduce the maintenance burden of needing to update the same code in multiple places.

Ah apologies, not sure what I was thinking there!

@eirichmond
Copy link
Contributor Author

Closing this PR to avoid confusion with #257

@eirichmond eirichmond closed this Sep 11, 2024
@eirichmond eirichmond reopened this Sep 11, 2024
@eirichmond
Copy link
Contributor Author

Reclosing this PR to avoid confusion with #257

@eirichmond eirichmond closed this Sep 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add comments section to all "single" templates

3 participants

Comments