Skip to content
This repository was archived by the owner on Nov 18, 2024. It is now read-only.

Conversation

@beafialho
Copy link
Contributor

@beafialho beafialho commented Sep 10, 2024

Description

I tested these templates and noticed a few things that needed adjustments. I'd appreciate a quick review.

Photo Single Post:

  • The layout wasn't looking as the intended design, so I adjusted blocks, spacings and sizes accordingly. This one is still missing the comments but I see that's being addressed in another PR.

Before:
https://github.com/user-attachments/assets/bcf60a5f-8ae8-40e4-b9a5-57081d71fe65

After:
https://github.com/user-attachments/assets/4cec2188-8335-44fe-8928-5be1459669cb

Photo Archive Template:

  • Adjusted the Term Description font size in global styles

Photo Search Results Template:

  • The search form had a size small, when it should have the default (Medium)

Photo Home Template:

  • Added the pill style to "Stories"

@github-actions
Copy link

github-actions bot commented Sep 10, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: beafialho <[email protected]>
Co-authored-by: carolinan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@carolinan
Copy link
Contributor

carolinan commented Sep 12, 2024

One question: Is the locking and the custom block names on the archive and search intentional?

@carolinan
Copy link
Contributor

carolinan commented Sep 12, 2024

Oh never mind, those were not added as part of this PR, and can be discussed separately.

@carolinan
Copy link
Contributor

The author name does not have a hover style, it is always underlined, both in its default state and on hover. This may be unrelated to the PR, so I will merge this.

@carolinan carolinan merged commit 252bd59 into trunk Sep 12, 2024
@juanfra juanfra deleted the photo-blog-templates-adjustments branch September 12, 2024 09:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants