This repository was archived by the owner on Nov 18, 2024. It is now read-only.
Update heading sizes and default home template #231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
carolinan
reviewed
Sep 6, 2024
Member
|
I believe we need to make a pass on the different patterns to get the sizes matching. |
This was referenced Sep 11, 2024
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the default home template looks like this if we add a post with some headings in the content:
It's not a good look that the post title is smaller than the subsequent headings from the post content.
So I tinkered with the heading sizes in global styles to see how we could solve this issue. I also checked with the patterns and although the scale of the headings in some of them is a bit smaller, I think they still look good. This is how it looks with the updated suggestion:
The sizes are the following:
H1: 2.62rem
H2: 1.8rem
H3: 1.64rem
H4: 1.5rem
H5: 1.25rem
H6: 0.875rem (Bold, uppercase, 1.4px letter spacing)
I also changed the font size of the "Blog" heading in the actual template.
Once these are reviewed, I'll update these heading sizes on the Figma file for coherency.