-
Notifications
You must be signed in to change notification settings - Fork 126
Add alternative templates/patterns for News Blog #215
Conversation
Adds alternative templates/patterns for News Blog mentioned in #133
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I've been playing a bit with this one:
@beafialho @carolinan can you please take a look at the changes and confirm that things are in place? Thanks |
| <!-- wp:group {"className":"is-style-default","style":{"spacing":{"padding":{"top":"var:preset|spacing|50","bottom":"var:preset|spacing|50"},"margin":{"top":"0","bottom":"0"}}},"layout":{"type":"constrained"}} --> | ||
| <div class="wp-block-group is-style-default" style="margin-top:0;margin-bottom:0;padding-top:var(--wp--preset--spacing--50);padding-bottom:var(--wp--preset--spacing--50)"><!-- wp:columns {"align":"wide","style":{"spacing":{"blockGap":{"left":"var:preset|spacing|50"}}}} --> | ||
| <div class="wp-block-columns alignwide"><!-- wp:column {"width":"75%"} --> | ||
| <div class="wp-block-column" style="flex-basis:75%"><!-- wp:query {"queryId":41,"query":{"perPage":1,"pages":0,"offset":0,"postType":"post","order":"desc","orderBy":"date","author":"","search":"","exclude":[],"sticky":"","inherit":false},"metadata":{"categories":["posts"],"patternName":"core/query-standard-posts","name":"Standard"}} --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the metadata need to be here for this core pattern to be used?
|
"News blog with featured posts grid" Is missing an H1 and the categories are above the headings, so screen reader users that navigate via headings will not get the information about the category. Instead the category is read as belonging under the previous heading, and this would be confusing since the actual category might be something else. The same posts are displayed twice. First in the main query and then in the list under the "Architecture" heading. "News blog with sidebar" is missing an H1: All headings have the same level which makes it difficult to navigate and prioritize the content. The heading "Latest" in the sidebar has the same heading level; the same importance, as all the blog posts. The main post is displayed three times, the other posts are displayed twice. In the list below the main post, the posts titles are not linked. "Offset post without featured image" is missing an H1. "Post with left aligned content" |
I have a doubt regarding this, can't the site title be H1? |
Moves categories below headings, adds H1 to templates, fixes repeated posts
|
Thank you for reviewing, I submitted some changes according to your feedback. |
Here are some resources I trust about heading levels: The site title in the header is not a good H1 for a few reasons: From a block theme perspective, a single pattern or template part can not change the HTML element for the title conditionally: it can't use an H1 on one specific page, and a paragraph on another. This was possible in classic themes. |
News blog with featured posts grid
I did not test how the page would look if there were less than five posts. News blog with sidebar
Offset post without featured image
Post with left aligned contentThe border above the next and previous posts link is full width, but perhaps that is the design choice. Changes to existing templatesNews blog home
|
I think this is expected since this is a template to be used when there are many posts.
That is correct, the border here is intended to be full width. Thank you for reviewing! |

Description
Adds alternative templates/patterns for News Blog mentioned in #133
There may be some discrepancies from the original Figma, this was intentional and built as looking good in the editor and front end.