Skip to content
This repository was archived by the owner on Nov 18, 2024. It is now read-only.
This repository was archived by the owner on Nov 18, 2024. It is now read-only.

Midnight: List of elements to adjust #549

@beafialho

Description

@beafialho

While testing the Midnight variation and its typography preset, I noticed some elements could be improved:

Image
Image

Here are the changes that can improve the look of the variation & typeset:

  • Post Author Name: reset styles
  • Post Terms: reset styles
  • Font size preset XXL: min 2rem, max 2.8rem
  • Font size preset XL: min 1.8rem, max 2.2rem
  • Font size preset L: min 1.2rem, max 1.8rem
  • Font size preset M: min 0.9rem, max 1.2rem
  • Font size preset S: 0.9rem
  • Text: set to font size preset M, letter spacing -0,01em, line height 1.5
  • Quote: reset font size (it should use the same preset as Text)
  • Pullquote: remove specific line height
  • Headings: line height 1.24
  • H6: remove specific font-weight (it should be the same as other headings, 300)
  • Buttons: set to font size preset M, font-weight: 400, letter spacing -0.01em
  • If it’s possible, can we remove Fira Sans Bold from the theme and whenever the Bold typography setting is selected and applied, it falls back to Fira Sans Medium? Mostly because Fira Sans Bold is appearing a bit harsh visually, probably because there’s no font smoothing, like there is on Figma.

How it's expected to look with the changes applied.

Image
Image
Image
Image

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions