Skip to content

Conversation

@psrpinto
Copy link
Member

@psrpinto psrpinto commented Dec 16, 2024

Fixes #167

There are no user-visible changes other than minor copy improvements.

@psrpinto psrpinto changed the base branch from trunk to import-buttons-schema December 16, 2024 16:09
@psrpinto psrpinto self-assigned this Dec 16, 2024
@psrpinto psrpinto requested a review from ashfame December 16, 2024 16:12
@psrpinto psrpinto marked this pull request as ready for review December 16, 2024 16:13
@psrpinto psrpinto linked an issue Dec 16, 2024 that may be closed by this pull request
Copy link
Member

@ashfame ashfame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Base automatically changed from import-buttons-schema to trunk December 16, 2024 16:48
@psrpinto psrpinto merged commit d186c99 into trunk Dec 16, 2024
3 checks passed
@psrpinto psrpinto deleted the no-hardcode-subject-type branch December 16, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Don't hardcode subject types

3 participants