Display import buttons for all registered subjects #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psrpinto
commented
Dec 16, 2024
Comment on lines
16
to
23
| // Pages get a specific button. | ||
| if ( subjectType === SubjectType.Page ) { | ||
| importButtons.push( { | ||
| text: `Import Pages`, | ||
| url: Screens.importPagesStart( session.id ), | ||
| } ); | ||
| return; | ||
| } |
Member
Author
There was a problem hiding this comment.
This is so that we maintain the behavior that was in place before this PR, which is that pages have a custom flow, where you manually import them one by one. I would like to not change this behavior in this PR, so that's why this code is here.
We can revisit this behavior in the future if we deem it necessary to change it.
psrpinto
commented
Dec 16, 2024
|
|
||
| const schema = schemas[ subjectType ]; | ||
| importButtons.push( { | ||
| text: `Import ${ schema.title }s`, |
Member
Author
There was a problem hiding this comment.
I opted for keeping the plural like this, we can revisit this when we tackle #158.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #155
There are no user-visible changes.