Skip to content

Make SubjectsApi automatically figure out which endpoints to call #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
psrpinto merged 1 commit into from
Dec 13, 2024
Merged

Make SubjectsApi automatically figure out which endpoints to call #160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions src/api/SubjectsApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,7 @@ import { ApiPost } from '@/api/ApiTypes';
import { newDateField } from '@/model/field/DateField';
import { newTextField } from '@/model/field/TextField';
import { newHtmlField } from '@/model/field/HtmlField';

const endpoints = new Map< string, string >( [
[ SubjectType.BlogPost, '/blog-posts' ],
[ SubjectType.Page, '/pages' ],
] );
import { getSchema } from '@/model/Schema';

export class SubjectsApi {
constructor( private readonly client: ApiClient ) {}
Expand Down Expand Up @@ -47,11 +43,8 @@ export class SubjectsApi {
}

function getEndpoint( type: SubjectType ): string {
const endpoint = endpoints.get( type );
if ( ! endpoint ) {
throw Error( `unknown endpoint: ${ type }` );
}
return endpoint;
const schema = getSchema( type );
return `/${ schema.slug }s`;
}

function fromApiResponse( response: ApiPost ): Subject {
Expand Down
Loading