-
Notifications
You must be signed in to change notification settings - Fork 7
Call schema validation from build process #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think the name of the plugin (EmitSubjectsSchemaPlugin) already provides enough information about what it does.
We don't want the build to succeed if something went wrong with the schema generation.
|
There's currently an issue that causes the |
|
Fixed in #150 |
|
Cool, thanks for fixing. Should we merge this one? Or you wanted to merge #150 into here? |
|
Yep, that works 👍 |
Infinite builds loop fix
ashfame
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done!
ashfame
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
This PR merges the
schemas/directory (#145) intoschema/(from #146).Additionally, it makes some extra changes:
schema.jsonat that point. So here I changedvalidate.mjsintobuild.mjswhich now does both validation and generation of the finalschema.json.schema.jsonfile is generated into theschema/directory itself, but hidden from gitbuild.mjsand then reads the generatedschema.json, instead of webpack itself having logic for generating the finalschema.json.schema/build.mjs), which can also be ran from the CLI.schema/subjectsdirectory, so that they are separate from all other filesbuild:schemascript topackage.json