Documentation for integrating and extending#125
Closed
Conversation
…_{post_type} hook
…onstant so other plugins can use it
psrpinto
approved these changes
Dec 2, 2024
Member
psrpinto
left a comment
psrpinto
left a comment
There was a problem hiding this comment.
Great work. I don't have any specific objections, and given there's already PRs that address some of the feedback, approving 👌
…_setting Abstract the act of storing references to Subject class
akirk
approved these changes
Dec 5, 2024
Closed
Closed
Member
Author
|
Closing as this was handled in sub-issues of #139 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides a WordPress-y API for integrating with data liberation.
See Rendered documentation
Apart from that, it has all the code changes required to support the behavior as per documentation along with some improvements. Can be reviewed commit by commit.
In a follow up PR, I can add tests for
SubjectandSubject_Repoclass.