Fix typos #42
Merged
Fix typos #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szepeviktor
commented
Jul 19, 2023
Comment on lines
-449
to
+453
| * @param unknonw $expression the statement to be evaluated as true or false. | ||
| * @param unknown $true statement or value returned if $expression is true. | ||
| * @param unknown $false statement or value returned if $expression is false. | ||
| * @param mixed $expression the statement to be evaluated as true or false. | ||
| * @param mixed $true statement or value returned if $expression is true. | ||
| * @param mixed $false statement or value returned if $expression is false. | ||
| * | ||
| * @return unknown | ||
| * @return mixed |
Contributor
Author
There was a problem hiding this comment.
There is no type called unknown.
szepeviktor
commented
Jul 19, 2023
| * If we are within a LIKE expression, we look for \_ and \%, the | ||
| * escaped LIKE wildcards, the ones where we want a literal, not a | ||
| * wildcard match. We change the \ escape for an ASCII \x1a (SUB) character, | ||
| * wildcard match. We change the \ escape for an ASCII \x1A (SUB) character, |
Contributor
Author
There was a problem hiding this comment.
Hexadecimal digits are usually written with uppercase letters.
aristath
approved these changes
Jul 20, 2023
Member
|
Thank you for working on this @szepeviktor! Merged 👍 |
Contributor
Author
|
Glad to contribute. |
JanJakes
added a commit
that referenced
this pull request
May 30, 2025
Database configuration and migration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found some misspellings with
typosand my eyes.