Skip to content

Conversation

@priethor
Copy link
Contributor

What

Skip the Block Bindings Site Editor e2e test on WordPress versions that don't support the feature.

Why

Block Bindings API was introduced in WordPress 6.5, and the tests were failing on WP 6.2 CI matrix.

How

Adding a version detection in test.beforeAll using branch-6-x body classes, and skipping the test suite if the version is older than 6.5.

Testing Instructions

  1. Run e2e tests against WP 6.2: binding tests should be skipped with the message Block Bindings API not available in WordPress versions < 6.5.
  2. Run e2e tests against WP 6.5+: test should execute normally.

@github-actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props priethor.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@codecov
Copy link

codecov bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 11.43%. Comparing base (5a894f5) to head (fc1f060).
⚠️ Report is 2 commits behind head on trunk.

Additional details and impacted files
@@             Coverage Diff              @@
##              trunk     #279      +/-   ##
============================================
- Coverage     11.51%   11.43%   -0.08%     
  Complexity     4285     4285              
============================================
  Files           284      284              
  Lines         34697    34697              
============================================
- Hits           3996     3969      -27     
- Misses        30701    30728      +27     
Flag Coverage Δ
e2e 29.55% <ø> (-1.16%) ⬇️
javascript 2.53% <ø> (ø)
phpunit 6.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@priethor priethor merged commit e0488b7 into trunk Dec 10, 2025
9 of 10 checks passed
@priethor priethor deleted the fix/e2e-should-not-test-bindings-under-wp65 branch December 10, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants