Skip to content

e2e tests: refactor meta box panel expansion to use Playwright methods #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cbravobernal merged 1 commit into from
Dec 1, 2025
Merged

e2e tests: refactor meta box panel expansion to use Playwright methods #259

cbravobernal merged 1 commit into from
Dec 1, 2025
+10 −14

Conversation

@priethor
Copy link
Contributor

@priethor priethor commented Nov 27, 2025 •
edited
Loading

Follow up to #257 (comment)

Refactors meta box panel expansion in e2e tests to use standard Playwright methods instead of page.evaluate()

@priethor priethor self-assigned this Nov 27, 2025
@codecov
Copy link

codecov bot commented Nov 27, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 7.48%. Comparing base (6ed176c) to head (41f1f09).
⚠️ Report is 7 commits behind head on trunk.

Additional details and impacted files 
@@           Coverage Diff           @@
##             trunk    #259   +/-   ##
=======================================
  Coverage     7.47%   7.48%           
  Complexity    4285    4285           
=======================================
  Files          265     265           
  Lines        33080   33080           
=======================================
+ Hits          2474    2477    +3     
+ Misses       30606   30603    -3
Flag Coverage Δ
e2e 21.83% <ø> (+0.04%) ⬆️
phpunit 3.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link

github-actions bot commented Nov 27, 2025 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props priethor, cbravobernal.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@priethor priethor mentioned this pull request Nov 27, 2025
Merged
cbravobernal
cbravobernal approved these changes Dec 1, 2025
View reviewed changes
Copy link
Contributor

@cbravobernal cbravobernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbravobernal cbravobernal merged commit bcc0958 into trunk Dec 1, 2025
9 of 10 checks passed
@cbravobernal cbravobernal deleted the fix/e2e-synthetic-events branch December 1, 2025 12:09
@cbravobernal cbravobernal added this to the 6.7.0 milestone Dec 2, 2025
@priethor priethor mentioned this pull request Dec 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbravobernal cbravobernal cbravobernal approved these changes

Assignees

@priethor priethor

Labels

[Type] Code Quality

Projects

None yet

Milestone

6.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@priethor @cbravobernal