-
Notifications
You must be signed in to change notification settings - Fork 47
Continuous Integration: Add WP version matrix to test PRs against WordPress trunk #257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #257 +/- ##
=======================================
Coverage 7.47% 7.47%
Complexity 4285 4285
=======================================
Files 265 265
Lines 33080 33080
=======================================
Hits 2474 2474
Misses 30606 30606
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Merging this as a blocker of #256, but feel free to add a post-merge review, @cbravobernal |
| btn.dispatchEvent( new MouseEvent( 'click', { bubbles: true } ) ); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, is not common to see this in e2e testing. You are opening all meta boxes by default here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's only opening the meta box panel at the bottom, but you are absolutely right we shouldn't be using synthetic events. Refactored to use standard Playwright methods in #259
What
Add WP version matrix to CI to test PRs against trunk, and fix failing tests against trunk.
Why
How
latest+trunk) to e2e workflowTesting Instructions
WP_ENV_CORE=WordPress/WordPress npm run test:e2e