-
Notifications
You must be signed in to change notification settings - Fork 47
Post Type Abilities: Add e2e tests #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #256 +/- ##
==========================================
+ Coverage 7.47% 7.96% +0.48%
Complexity 4285 4285
==========================================
Files 265 265
Lines 33080 33076 -4
==========================================
+ Hits 2474 2635 +161
+ Misses 30606 30441 -165
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cbravobernal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just added small nitpicks. Tests are always beneficial 🚀
|
@cbravobernal, apart from cleaning up the comments, I've changed the e2e matrix to test PRs against trunk, as with versions lower than 6.9 the Abilities tests are skipped because there is no Abilities API. This made some repeater field tests fail; could you check if it is just flakiness or something changed? |
Addressed in #257 |
48dc3e2 to
ba61099
Compare
|
Rebased the PR to get the changes from #257; all tests now pass, without being skipped, against WP trunk. |
What
Add comprehensive e2e tests for SCF Post Type Abilities.
Why
Ensures the Post Type abilities work correctly through the WordPress Abilities API
How
tests/e2e/abilities-post-types.spec.tsTesting Instructions
npm run test:e2e tests/e2e/abilities-post-types.spec.ts