Skip to content

Restricted Headers: remove ones that are allowed, but leave the mech for checking in place for future use #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chriscct7 merged 2 commits into from
Oct 15, 2024
Merged

Restricted Headers: remove ones that are allowed, but leave the mech for checking in place for future use #720

chriscct7 merged 2 commits into from
Oct 15, 2024

Conversation

@kraftbj
Copy link
Contributor

@kraftbj kraftbj commented Oct 14, 2024 •
edited by swissspidy
Loading

Partly reverts the functionality of #670.
Resolves #718

Per the conversation in #669, the presence of these headers—in and of themselves—do not create a third-party upgrader situation. The UpdateURI, which is already checked elsewhere, does prevent the updates from WordPress.org, but the headers originally included in this code are for information only.

@github-actions
Copy link

github-actions bot commented Oct 14, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @octalmage.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: octalmage.

Co-authored-by: kraftbj <[email protected]>
Co-authored-by: sc0ttkclark <[email protected]>
Co-authored-by: dd32 <[email protected]>
Co-authored-by: afragen <[email protected]>
Co-authored-by: danieliser <[email protected]>
Co-authored-by: xwolfde <[email protected]>
Co-authored-by: ernilambar <[email protected]>
Co-authored-by: sybrew <[email protected]>
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: alvarogois <[email protected]>
Co-authored-by: jb510 <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@afragen
Copy link
Member

afragen commented Oct 14, 2024

Thank you Brandon.

sc0ttkclark
sc0ttkclark approved these changes Oct 14, 2024
View reviewed changes
Copy link

@sc0ttkclark sc0ttkclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes a lot of sense and keeps the functionality available for problematic comments that could be moved in here like the one which lets you override the Update URI (https://make.wordpress.org/core/2021/06/29/introducing-update-uri-plugin-header-in-wordpress-5-8/)

@afragen afragen mentioned this pull request Oct 14, 2024
Closed
@danieliser
Copy link

danieliser commented Oct 14, 2024

I approve this! ☝️

@chriscct7 chriscct7 requested review from chriscct7 and removed request for chriscct7 October 14, 2024 21:39
@xwolfde
Copy link

xwolfde commented Oct 14, 2024

Thank you!

@dd32 dd32 assigned dd32 and chriscct7 and unassigned dd32 Oct 15, 2024
@dd32
Copy link
Member

dd32 commented Oct 15, 2024

I've chatted with @chriscct7 and I agree with reverting this change for now, assigning it to him to handle.

@chriscct7 chriscct7 requested review from chriscct7 and removed request for barrykooij, davidperezgar, ernilambar and frantorres October 15, 2024 03:42
@chriscct7 chriscct7 modified the milestone: 1.3.0 Oct 15, 2024
@chriscct7 chriscct7 added Checks Audit/test of the particular part of the plugin [Team] Plugins Issues owned by Plugins Team labels Oct 15, 2024
@chriscct7 chriscct7 added the [Type] Bug An existing feature is broken label Oct 15, 2024
@chriscct7 chriscct7 merged commit e993242 into WordPress:trunk Oct 15, 2024
@lucprincen
Copy link

lucprincen commented Oct 15, 2024

Thank you!

@kraftbj kraftbj deleted the update/header-check branch October 15, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dd32 dd32 dd32 approved these changes

@chriscct7 chriscct7 chriscct7 approved these changes

+1 more reviewer

@sc0ttkclark sc0ttkclark sc0ttkclark approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chriscct7 chriscct7

Labels

Checks Audit/test of the particular part of the plugin [Team] Plugins Issues owned by Plugins Team [Type] Bug An existing feature is broken

Projects

None yet

Milestone

1.3.0

Development

Successfully merging this pull request may close these issues.

Git Updater headers now listed as an ERROR for plugin_header_restricted_fields

8 participants

@kraftbj @afragen @danieliser @xwolfde @dd32 @lucprincen @sc0ttkclark @chriscct7