Skip to content

When checking for excluded files, use the normalized path to ensure that it works in Windows environments. #694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
swissspidy merged 4 commits into from
Oct 23, 2024
Merged

When checking for excluded files, use the normalized path to ensure that it works in Windows environments. #694

swissspidy merged 4 commits into from
Oct 23, 2024

Conversation

@pbiron
Copy link
Contributor

@pbiron pbiron commented Oct 3, 2024

Fixes #693

@github-actions
Copy link

github-actions bot commented Oct 3, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: pbiron <[email protected]>
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: davidperezgar <[email protected]>
Co-authored-by: ernilambar <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@pbiron
Remove an unnessary wp_normalize_path() in Abstract_File_Check::get_f…
a179db5 
…iles().

This probably should have been removed in WordPress#592, but was forgotten.
@pbiron
Copy link
Contributor Author

pbiron commented Oct 8, 2024

@davidperezgar can you please look at this PR before v1.2.0 ships?

@davidperezgar
Copy link
Member

davidperezgar commented Oct 8, 2024

I don't know for sure, we're in final stages of version.

@pbiron
Copy link
Contributor Author

pbiron commented Oct 8, 2024

the reason I would really like to get it into 1.2.0 is that it is a follow-up to #592 which will be included in 1.2.0. #592 fixed one prob for the WP_CLI command in Windows but missed another one.

@swissspidy swissspidy added this to the 1.3.0 milestone Oct 11, 2024
@ernilambar
Copy link
Member

ernilambar commented Oct 20, 2024

I don't have Windows setup to test the PR. Can someone please verify who is in Windows OS?

@swissspidy
Copy link
Member

swissspidy commented Oct 23, 2024

I trust that @pbiron did the necessary testing when fixing this bug on their machine :)

@swissspidy swissspidy merged commit 341b335 into WordPress:trunk Oct 23, 2024
2 checks passed
@pbiron pbiron deleted the cli-exclude-files-windows branch October 23, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swissspidy swissspidy swissspidy approved these changes

@ernilambar ernilambar ernilambar approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.3.0

Development

Successfully merging this pull request may close these issues.

CLI: ensure --exclude-files works in Windows

4 participants

@pbiron @davidperezgar @ernilambar @swissspidy