Skip to content

Add i18n usage check class and test plugin files for unit tests #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mukeshpanchal27 merged 15 commits into from
Feb 3, 2023
Merged

Add i18n usage check class and test plugin files for unit tests #62

mukeshpanchal27 merged 15 commits into from
Feb 3, 2023

Conversation

@vishalkakadiya
Copy link

@vishalkakadiya vishalkakadiya commented Jan 19, 2023 •
edited
Loading

Adds the I18n_Usage_Check class

Closes #18

@vishalkakadiya vishalkakadiya marked this pull request as draft January 19, 2023 05:59
@vishalkakadiya vishalkakadiya changed the title WIP: Add i18n usage check class Add i18n usage check class and test plugin files for unit tests Jan 20, 2023
@vishalkakadiya vishalkakadiya marked this pull request as ready for review January 20, 2023 14:19
mukeshpanchal27
mukeshpanchal27 requested changes Jan 23, 2023
View reviewed changes
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vishalkakadiya, Good start! Left some feedback and questions.

@vishalkakadiya
Copy link
Author

vishalkakadiya commented Jan 23, 2023

@mukeshpanchal27 I have addressed the feedback and replied to your comments. Thank you! 🙂

@vishalkakadiya vishalkakadiya linked an issue Jan 24, 2023 that may be closed by this pull request
Create I18n_Usage_Check #18
Closed
jjgrainger
jjgrainger requested changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@jjgrainger jjgrainger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vishalkakadiya

Overall looking good and have left feedback on a number of things.

@vishalkakadiya
Copy link
Author

vishalkakadiya commented Jan 25, 2023

@jjgrainger I have addressed your feedback now and left one question for you. Thank you!

@jjgrainger jjgrainger self-requested a review January 27, 2023 15:44
jjgrainger
jjgrainger approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@jjgrainger jjgrainger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vishalkakadiya approved.

@vishalkakadiya
Copy link
Author

vishalkakadiya commented Feb 1, 2023

@jjgrainger Thank you! 🙌

@felixarntz It is ready for your review now. Thank you! 🙂

felixarntz
felixarntz requested changes Feb 1, 2023
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishalkakadiya Mostly LGTM, but a few small things that need to be fixed.

Vishal Kakadiya and others added 2 commits February 2, 2023 17:22
@vishalkakadiya
Copy link
Author

vishalkakadiya commented Feb 2, 2023

@felixarntz I have addressed the feedback on it. Please review it now. Thank you! 🙂

felixarntz
felixarntz approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vishalkakadiya Looks great, thanks!

mukeshpanchal27
mukeshpanchal27 approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vishalkakadiya, The changes look good to me. Great work!

@mukeshpanchal27 mukeshpanchal27 merged commit 11cf592 into trunk Feb 3, 2023
@mukeshpanchal27 mukeshpanchal27 deleted the feature/create-translation-check-class branch February 3, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjgrainger jjgrainger jjgrainger approved these changes

@felixarntz felixarntz felixarntz approved these changes

@mukeshpanchal27 mukeshpanchal27 mukeshpanchal27 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create I18n_Usage_Check

5 participants

@vishalkakadiya @jjgrainger @felixarntz @mukeshpanchal27