Create Check_Context class #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjgrainger
added
[Type] Enhancement
felixarntz
approved these changes
Dec 21, 2022
Member
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
@jjgrainger All good, except the same pending feedback for #47 applies here too.
| public function test_url_with_parameter() { | ||
| $this->assertSame( site_url( '/wp-content/plugins/test-plugin/folder/file.css' ), $this->check_context->url( '/folder/file.css' ) ); | ||
| } | ||
| } |
mukeshpanchal27
approved these changes
Dec 22, 2022
Member
mukeshpanchal27
left a comment
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thanks @jjgrainger We were ready to go once Felix's feedback was addressed.
bordoni
pushed a commit
that referenced
this pull request
Sep 13, 2023
* Update Build to push to plugins.svn * Create readme.txt * Move from build to Release workflow. NOTE: This assumes that releases are built from the 'build' branch, rather than from 'trunk' with development files. This might need to be changed to (conditionally perhaps) run the build steps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
Check_ContextclassPlugin_Context_Tests.phpCloses #10