throw exception if post cannot be found

jjgrainger · jjgrainger · commit b6e5e564aa9a · 2023-03-14T13:39:31.000Z
diff --git a/includes/Checker/Checks/Enqueued_Scripts_Size_Check.php b/includes/Checker/Checks/Enqueued_Scripts_Size_Check.php
@@ -130,6 +130,8 @@ function ( $url ) use ( $result ) {
 	 * @since n.e.x.t
 	 *
 	 * @return array List of URL strings (either full URLs or paths).
+	 *
+	 * @throws Exception Thrown when a post type URL cannot be retrieved.
 	 */
 	protected function get_urls() {
 		$urls = array( home_url() );
@@ -139,12 +141,21 @@ protected function get_urls() {
 				array(
 					'posts_per_page' => 1,
 					'post_type'      => $post_type,
-					'post_status'    => 'publish',
+					'post_status'    => array( 'publish', 'inherit' ),
 				)
 			);
-			if ( isset( $posts[0] ) ) {
-				$urls[] = get_permalink( $posts[0] );
+
+			if ( ! isset( $posts[0] ) ) {
+				throw new Exception(
+					sprintf(
+						/* translators: %s: The Post Type name. */
+						__( 'Unable to retrieve post URL for post type: %s', 'plugin-check' ),
+						$post_type
+					)
+				);
 			}
+
+			$urls[] = get_permalink( $posts[0] );
 		}
 
 		return $urls;
diff --git a/tests/Checker/Checks/Enqueued_Scripts_Size_Check_Tests.php b/tests/Checker/Checks/Enqueued_Scripts_Size_Check_Tests.php
@@ -94,7 +94,7 @@ public function test_run_with_errors() {
 		$this->assertNotEmpty( $warnings );
 
 		$this->assertEquals( 0, $results->get_error_count() );
-		$this->assertEquals( 3, $results->get_warning_count() );
+		$this->assertEquals( 4, $results->get_warning_count() );
 	}
 
 	public function test_run_with_errors_for_inline_script() {
@@ -113,6 +113,6 @@ public function test_run_with_errors_for_inline_script() {
 		$this->assertNotEmpty( $warnings );
 
 		$this->assertEquals( 0, $results->get_error_count() );
-		$this->assertEquals( 3, $results->get_warning_count() );
+		$this->assertEquals( 4, $results->get_warning_count() );
 	}
 }
diff --git a/tests/Checker/Preparations/Demo_Posts_Creation_Preparation_Tests.php b/tests/Checker/Preparations/Demo_Posts_Creation_Preparation_Tests.php
@@ -61,6 +61,7 @@ public function test_prepare_throws_exception() {
 		$this->expectException( 'Exception' );
 		$this->expectExceptionMessage( 'Content, title, and excerpt are empty.' );
 
-		$preparation->prepare();
+		$cleanup = $preparation->prepare();
+		$cleanup();
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ public function test_run_with_errors() {`
`94`	`94`	`$this->assertNotEmpty( $warnings );`
`95`	`95`
`96`	`96`	`$this->assertEquals( 0, $results->get_error_count() );`
`97`		`- $this->assertEquals( 3, $results->get_warning_count() );`
	`97`	`+ $this->assertEquals( 4, $results->get_warning_count() );`
`98`	`98`	`}`
`99`	`99`
`100`	`100`	`public function test_run_with_errors_for_inline_script() {`
`@@ -113,6 +113,6 @@ public function test_run_with_errors_for_inline_script() {`
`113`	`113`	`$this->assertNotEmpty( $warnings );`
`114`	`114`
`115`	`115`	`$this->assertEquals( 0, $results->get_error_count() );`
`116`		`- $this->assertEquals( 3, $results->get_warning_count() );`
	`116`	`+ $this->assertEquals( 4, $results->get_warning_count() );`
`117`	`117`	`}`
`118`	`118`	`}`
Original file line number	Diff line number	Diff line change
`@@ -61,6 +61,7 @@ public function test_prepare_throws_exception() {`
`61`	`61`	`$this->expectException( 'Exception' );`
`62`	`62`	`$this->expectExceptionMessage( 'Content, title, and excerpt are empty.' );`
`63`	`63`
`64`		`- $preparation->prepare();`
	`64`	`+ $cleanup = $preparation->prepare();`
	`65`	`+ $cleanup();`
`65`	`66`	`}`
`66`	`67`	`}`