Playground block: Update CodeMirror deps for a11y fix #317
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR updates CodeMirror dependencies to include a recent accessibility-related autocomplete fix:
https://discuss.codemirror.net/t/avoiding-aria-autocomplete-list-when-no-autocompletion-providers/8313/2
Why?
Fixes #289 - "Playground block: A11Y: Use correct ARIA specification for autocomplete"
Implementation
This PR updates npm dependencies for CodeMirror. The Playground block appears to work well with the update.
The interactive-code-block doesn't render well in the editor either before or after these updates. (Is it still in use anywhere, and if not, can we delete it? cc @adamziel)
Testing Instructions
npm installupdate dependenciesnpx nx dev wordpress-playground-blockto build the block and start a dev server$$('[aria-autocomplete]'), and confirm the query returns an element$$('[aria-autocomplete]'), and confirm the query returns an empty list