Skip to content

Add silly debug flags for npm debugging #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ronilaukkarinen wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add silly debug flags for npm debugging #221

ronilaukkarinen wants to merge 1 commit into from

Conversation

@ronilaukkarinen
Copy link

@ronilaukkarinen ronilaukkarinen commented May 16, 2024

This adds verbose debug flags in case of npm commands hang or behave unexpectedly.

@ronilaukkarinen ronilaukkarinen mentioned this pull request May 16, 2024
Closed
pfefferle
pfefferle reviewed Jun 18, 2024
View reviewed changes
Copy link
Member

@pfefferle pfefferle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make it configurable by supporting the env var WPT_DEBUG?

https://github.com/WordPress/phpunit-test-runner/blob/master/.env.default#L62

You see an example here:

phpunit-test-runner/prepare.php

Line 33 in 6fc0d25

* Determines if the debug mode is enabled based on the 'WPT_DEBUG' environment variable.

@javiercasares javiercasares self-assigned this Oct 2, 2024
@mindctrl
Copy link

mindctrl commented Dec 10, 2025

I wonder if we still need this since #222 was solved with #225? If we still want it, I like the idea of making it configurable via WPT_DEBUG like @pfefferle suggested.

@github-actions
Copy link

github-actions bot commented Dec 10, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ronilaukkarinen <[email protected]>
Co-authored-by: pfefferle <[email protected]>
Co-authored-by: mindctrl <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pfefferle pfefferle pfefferle left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

ContributorDay

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ronilaukkarinen @mindctrl @pfefferle @javiercasares @kittenkamala