Skip to content

Fix incorrect parameter name for Google system instruction#178

Merged
JasonTheAdams merged 2 commits intotrunkfrom
fix/google-system-instruction
Jan 22, 2026
Merged

Fix incorrect parameter name for Google system instruction#178
JasonTheAdams merged 2 commits intotrunkfrom
fix/google-system-instruction

Conversation

@felixarntz
Copy link
Member

@felixarntz felixarntz commented Jan 22, 2026

@felixarntz felixarntz added the [Type] Bug An existing feature does not function as intended label Jan 22, 2026
@github-actions
Copy link

github-actions bot commented Jan 22, 2026

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @mademan12.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: mademan12.

Co-authored-by: felixarntz <[email protected]>
Co-authored-by: JasonTheAdams <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@felixarntz felixarntz added this to the 0.4.1 milestone Jan 22, 2026
@JasonTheAdams
Copy link
Member

@felixarntz Am I correct in looking at the instructions you linked to that systemInstruction is actually meant to be a Content object (as opposed to a string)? It says it only supports text, but it sounds like it may mean that as parts and such. But maybe I'm misreading that.

@felixarntz
Copy link
Member Author

@JasonTheAdams Yikes! You're right. Fixed in a27a8f2

Tested it via --systemInstruction in our cli.php and confirmed that it works.

@JasonTheAdams JasonTheAdams merged commit bc18a49 into trunk Jan 22, 2026
6 checks passed
@JasonTheAdams JasonTheAdams deleted the fix/google-system-instruction branch January 22, 2026 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Google Provider: System Instructions Not Working - With version 0.4.0

2 participants