Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin directory assets for Speculation Rules #987

Merged

Conversation

westonruter
Copy link
Member

@westonruter westonruter commented Feb 14, 2024

See #969

I compressed the Figma exports with Squoosh and OMGSVG.

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@domenic
Copy link

domenic commented Feb 15, 2024

I might be missing something, but these assets seem to say "SP"; should they say "SR" instead?

Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @domenic.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: domenic.

Co-authored-by: westonruter <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@westonruter
Copy link
Member Author

@domenic the convention for the plugins has been to use the first two letters and not the initials, though I agree it's not really clear. There has been some initial discussions about changing that convention. cc @eclarke1

@westonruter westonruter added the [Plugin] Speculative Loading Issues for the Speculative Loading plugin (formerly Speculation Rules) label Feb 15, 2024
@swissspidy swissspidy merged commit df10806 into feature/speculationrules Feb 15, 2024
@swissspidy swissspidy deleted the add/speculation-rules-plugin-assets branch February 15, 2024 07:04
@swissspidy swissspidy added this to the PL Plugin 2.9.0 milestone Feb 15, 2024
@westonruter westonruter removed this from the PL Plugin 2.9.0 milestone Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no milestone PRs that do not have a defined milestone for release [Plugin] Speculative Loading Issues for the Speculative Loading plugin (formerly Speculation Rules)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants