Skip to content

Merge feature/modules-to-plugins into feature/auto-sizes #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mukeshpanchal27 wants to merge 27 commits into from
Closed

Merge feature/modules-to-plugins into feature/auto-sizes #975

mukeshpanchal27 wants to merge 27 commits into from

Conversation

@mukeshpanchal27
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 commented Feb 7, 2024

I need approval to merge the changes already committed to the feature branch.

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

mukeshpanchal27 and others added 27 commits January 18, 2024 12:25
@mukeshpanchal27
Add plugins folder
aa2437d
@mukeshpanchal27
ignore plugins folder
c366c91
@mukeshpanchal27
Restructure the plugins.json file
2ebdda4
@mukeshpanchal27
Update build-plugins script
c59f9f9
@mukeshpanchal27
Update test-plugins script
5ab7268
@mukeshpanchal27
Update Deploy standalone plugins workflow
177b2e9
@mukeshpanchal27
Add plugins in tooling
c55b3e6
@mukeshpanchal27
Merge branch 'feature/modules-to-plugins' into add/934-plugins-folder
7c3d1d1
@mukeshpanchal27 @swissspidy
Apply suggestions from code review
7df015d 
Co-authored-by: Pascal Birchler <[email protected]>
@mukeshpanchal27
Update variable names
643d78b
@mukeshpanchal27
Remove the temporary changes
b0bad91
@felixarntz
Merge pull request #948 from WordPress/add/934-plugins-folder
16fda54 
Introduce plugins folder for standalone plugins
@mukeshpanchal27
Plugin test suite
dbe1a99
@mukeshpanchal27
Add test file
cef64a3
@mukeshpanchal27
Run test for branch
8a40b2c
@mukeshpanchal27
Update test command
43b630a
@mukeshpanchal27
Update unit test command
54ca2e6
@westonruter
Merge pull request #959 from WordPress/trunk
218a69d 
Merge trunk into feature/modules-to-plugins
@mukeshpanchal27
Merge branch 'feature/modules-to-plugins' into add/plugins-test-suite
7c92bc0
@mukeshpanchal27
Add another test
4d18663
@mukeshpanchal27
Merge branch 'add/plugins-test-suite' of github.com:WordPress/perform…
2b9693f 
…ance into add/plugins-test-suite
@mukeshpanchal27
Merge pull request #968 from WordPress/trunk
8c04816 
Merge trunk into feature/modules-to-plugins
@mukeshpanchal27
Merge branch 'feature/modules-to-plugins' into add/plugins-test-suite
f47b1f8
@mukeshpanchal27
Revert changes
c75b3dc
@mukeshpanchal27
Adjust composer update
ecd9d21
@mukeshpanchal27
Update plugin name to Test Plugin
500fb91
@mukeshpanchal27
Merge pull request #956 from WordPress/add/plugins-test-suite
4c21e8f 
Add test suite for Plugins folder
@mukeshpanchal27 mukeshpanchal27 added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release labels Feb 7, 2024
@mukeshpanchal27 mukeshpanchal27 mentioned this pull request Feb 7, 2024
Merged
3 tasks
@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review February 7, 2024 07:55
@github-actions
Copy link

github-actions bot commented Feb 7, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

Core Committers: Use this line as a base for the props when committing in SVN:

Props mukesh27, flixos90, westonruter, swissspidy, joemcgill.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mukeshpanchal27 <[email protected]>
Co-authored-by: felixarntz <[email protected]>
Co-authored-by: westonruter <[email protected]>
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: joemcgill <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

joemcgill
joemcgill requested changes Feb 7, 2024
View reviewed changes
Copy link
Member

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ I'm confused about why we are merging the feature/modules-to-plugins branch into the feature/auto-sizes branch, when #904 suggests the opposite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joemcgill joemcgill joemcgill requested changes

@westonruter westonruter westonruter approved these changes

@swissspidy swissspidy swissspidy approved these changes

@aristath aristath Awaiting requested review from aristath

@felixarntz felixarntz Awaiting requested review from felixarntz

Assignees

No one assigned

Labels

Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mukeshpanchal27 @westonruter @joemcgill @swissspidy @felixarntz