Prepare the auto-sizes module as a standalone plugin #922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joemcgill
added
[Focus] Images
no milestone
3 tasks
felixarntz
approved these changes
Jan 5, 2024
Member
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
@joemcgill LGTM, just one readme docs recommendation.
Specifically reference `sizes="auto"` in the description, rather than "auto sizes". Co-authored-by: Felix Arntz <[email protected]>
mukeshpanchal27
approved these changes
Jan 8, 2024
Member
mukeshpanchal27
left a comment
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thank you, @joemcgill, for the PR! I've provided one non-blocking feedback. Aside from that, everything appears to be in good from my perspective.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This updates the auto-sizes module feature to prepare for merging into trunk. Included in this change:
See: #904
Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.