Skip to content

Implement admin pointer to indicate to the user they need to migrate modules to their standalone plugins#910

Merged
felixarntz merged 7 commits intofeature/creating-standalone-pluginsfrom
fix/653-add-module-migration-pointer
Dec 19, 2023
Merged

Implement admin pointer to indicate to the user they need to migrate modules to their standalone plugins#910
felixarntz merged 7 commits intofeature/creating-standalone-pluginsfrom
fix/653-add-module-migration-pointer

Conversation

@mukeshpanchal27
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 commented Dec 18, 2023 •
edited
Loading

Summary

Fixes #653

Prior to merging this PR, we'll need to ensure that #899 is merged.

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@mukeshpanchal27 mukeshpanchal27 added [Type] Enhancement A suggestion for improvement of an existing feature no milestone PRs that do not have a defined milestone for release Creating standalone plugins labels Dec 18, 2023
@mukeshpanchal27 mukeshpanchal27 self-assigned this Dec 18, 2023
@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review December 18, 2023 08:47
swissspidy
swissspidy reviewed Dec 18, 2023
View reviewed changes
swissspidy
swissspidy reviewed Dec 18, 2023
View reviewed changes
Base automatically changed from wip/652 to feature/creating-standalone-plugins December 18, 2023 10:10
felixarntz
felixarntz requested changes Dec 18, 2023
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mukeshpanchal27. This looks good, though I left a few suggestions for improving the new function which is a bit too specifically tied to a UI consideration only relevant in one place.

@felixarntz
Copy link
Member

felixarntz commented Dec 18, 2023

Another thought on this (which if we go for it, we could implement in a separate PR): We may want to "un-dismiss" the migration pointer when the user activates a module? This would ensure that, if the user brings the site back into a "problematic" state after initially having fixed the problem, the pointer shows again. I think that would be helpful, especially if the logic here remains in the plugin indefinitely (see related #904 (comment)). We could just always remove the pointer from being dismissed whenever a module is activated, as the pointer would only actually show anyway if relevant for the site's current state.

WDYT @mukeshpanchal27 @swissspidy?

westonruter
westonruter reviewed Dec 18, 2023
View reviewed changes
@mukeshpanchal27
Copy link
Member Author

mukeshpanchal27 commented Dec 19, 2023

Another thought on this (which if we go for it, we could implement in a separate PR): We may want to "un-dismiss" the migration pointer when the user activates a module?

Yes. IMO we should do that.

felixarntz
felixarntz approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mukeshpanchal27, looks great!

@felixarntz
Copy link
Member

felixarntz commented Dec 19, 2023

Another thought on this (which if we go for it, we could implement in a separate PR): We may want to "un-dismiss" the migration pointer when the user activates a module?

Yes. IMO we should do that.

Thanks @mukeshpanchal27. Can you open a follow up PR for this when you get a chance? Not a blocker for the release, but a nice to have enhancement.

@felixarntz felixarntz merged commit 28b8905 into feature/creating-standalone-plugins Dec 19, 2023
@felixarntz felixarntz deleted the fix/653-add-module-migration-pointer branch December 19, 2023 16:05
@mukeshpanchal27 mukeshpanchal27 mentioned this pull request Dec 20, 2023
Merged
3 tasks
@felixarntz felixarntz mentioned this pull request Dec 21, 2023
Closed
@felixarntz felixarntz added the Infrastructure Issues for the overall performance plugin infrastructure label Jan 4, 2024
@felixarntz felixarntz added this to the PL Plugin 2.8.0 milestone Jan 4, 2024
@felixarntz felixarntz removed the no milestone PRs that do not have a defined milestone for release label Jan 4, 2024
@felixarntz felixarntz changed the title Implement admin pointer to indicate to the user they need to activate the new standalone plugins Implement admin pointer to indicate to the user they need to migrate modules to their standalone plugins Jan 4, 2024
@felixarntz felixarntz mentioned this pull request Jan 4, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@westonruter westonruter westonruter left review comments

@swissspidy swissspidy swissspidy approved these changes

@felixarntz felixarntz felixarntz approved these changes

@joemcgill joemcgill Awaiting requested review from joemcgill

@JustinyAhin JustinyAhin Awaiting requested review from JustinyAhin

Assignees

@mukeshpanchal27 mukeshpanchal27

Labels

Infrastructure Issues for the overall performance plugin infrastructure [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Milestone

PL Plugin 2.8.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mukeshpanchal27 @felixarntz @westonruter @swissspidy