Add support for plugin live preview in the plugin directory#890
Merged
swissspidy merged 1 commit intotrunkfrom Nov 30, 2023
Merged
Add support for plugin live preview in the plugin directory#890swissspidy merged 1 commit intotrunkfrom
swissspidy merged 1 commit intotrunkfrom
Conversation
mukeshpanchal27
added
[Type] Enhancement
mukeshpanchal27
added
the
Infrastructure
Member
Author
|
I've added the |
felixarntz
reviewed
Nov 30, 2023
Member
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
Thanks @mukeshpanchal27, this looks solid.
I only have one question - not sure whether this is required or not, so let's clarify that first.
felixarntz
changed the title
felixarntz
removed
the
no milestone
felixarntz
approved these changes
Nov 30, 2023
swissspidy
approved these changes
Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #885
The PR enable live preview support for Performance lab plugin. I can't added the support for standalone plugin because they don't have any settings page.
Note: When we implemented site health related checks in modules then they it will be automatically disable in Playground environment.
Relevant technical choices
Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.