Skip to content

Bump minimum required PHP version to 7.0 and minimum required WP version to 6.3#851

Merged
swissspidy merged 8 commits intotrunkfrom
fix/606-bump-minimum-php-wp-7
Oct 11, 2023
Merged

Bump minimum required PHP version to 7.0 and minimum required WP version to 6.3#851
swissspidy merged 8 commits intotrunkfrom
fix/606-bump-minimum-php-wp-7

Conversation

@mukeshpanchal27
Copy link
Member

@mukeshpanchal27 mukeshpanchal27 commented Oct 10, 2023

Summary

Fixes #606

  • Bump main plugin minimum required WP version to 6.3
  • Bump standalone plugin minimum required WP version to 6.3.
  • Bump main plugin minimum required PHP version to 7.0.
  • Bump standalone plugin minimum required PHP version to 7.0.
  • Update/remove legacy code.

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@mukeshpanchal27 mukeshpanchal27 added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release labels Oct 10, 2023
@mukeshpanchal27 mukeshpanchal27 self-assigned this Oct 10, 2023
@mukeshpanchal27
Copy link
Member Author

mukeshpanchal27 commented Oct 10, 2023

@felixarntz, should we include the update of the standalone plugin version as part of this PR, or would it be better to handle it in a separate PR?

@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review October 10, 2023 10:42
spacedmonkey
spacedmonkey reviewed Oct 10, 2023
View reviewed changes
swissspidy
swissspidy reviewed Oct 10, 2023
View reviewed changes
felixarntz
felixarntz approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mukeshpanchal27, LGTM!

Happy to merge this despite the one outstanding point mentioned by @swissspidy. Let's open a separate PR for that, should be a quick one.

@felixarntz
Copy link
Member

felixarntz commented Oct 10, 2023 •
edited
Loading

@mukeshpanchal27

@felixarntz, should we include the update of the standalone plugin version as part of this PR, or would it be better to handle it in a separate PR?

Just saw this comment. How about we merge this PR as is, and then open another PR that does the following:

  • remove Fetchpriority module/plugin completely
  • bump patch version of WebP Uploads plugin

See the new #853.

Note that Dominant Color Images doesn't need any version bump because it's not released yet anyway.

cc @swissspidy

@felixarntz felixarntz requested a review from swissspidy October 10, 2023 16:09
@felixarntz felixarntz mentioned this pull request Oct 10, 2023
Closed
@spacedmonkey
Copy link
Member

spacedmonkey commented Oct 10, 2023

Composer install is not failing.

aristath
aristath approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@aristath aristath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Pre-approving, pending the fix for a failing composer issue

@swissspidy swissspidy merged commit 916e134 into trunk Oct 11, 2023
@swissspidy swissspidy deleted the fix/606-bump-minimum-php-wp-7 branch October 11, 2023 08:46
@felixarntz felixarntz added this to the PL Plugin 2.7.0 milestone Oct 12, 2023
@felixarntz felixarntz removed the no milestone PRs that do not have a defined milestone for release label Oct 12, 2023
@mukeshpanchal27 mukeshpanchal27 mentioned this pull request Oct 18, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spacedmonkey spacedmonkey spacedmonkey left review comments

@aristath aristath aristath approved these changes

@felixarntz felixarntz felixarntz approved these changes

@pbearne pbearne Awaiting requested review from pbearne

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein

@mitogh mitogh Awaiting requested review from mitogh

@JustinyAhin JustinyAhin Awaiting requested review from JustinyAhin

@joemcgill joemcgill Awaiting requested review from joemcgill

@10upsimon 10upsimon Awaiting requested review from 10upsimon

@swissspidy swissspidy Awaiting requested review from swissspidy

Assignees

@mukeshpanchal27 mukeshpanchal27

Labels

Infrastructure Issues for the overall performance plugin infrastructure [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Milestone

PL Plugin 2.7.0

Development

Successfully merging this pull request may close these issues.

Bump minimum required PHP version to 7.0 and minimum required WP version to 6.3

6 participants

@mukeshpanchal27 @felixarntz @spacedmonkey @aristath @joemcgill @swissspidy