Fix WebP handling when editing images based on WordPress 6.3 change#796
Fix WebP handling when editing images based on WordPress 6.3 change#796mukeshpanchal27 merged 7 commits intotrunkfrom
Conversation
|
@joemcgill Turns out there is a breaking change in WordPress 6.3 😞 Not sure if it's worth fixing since it's a very low-level function, but in any case I opened https://core.trac.wordpress.org/ticket/59040 for consideration. |
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thanks @felixarntz for the PR. Left one question.
With the changes we have to update WebP Uploads plugin.
Co-authored-by: Mukesh Panchal <[email protected]>
Good catch! I've prepared the WebP Uploads standalone plugin for the update in 65b5fdc. |
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thanks @felixarntz for the changes. LGTM!
|
@joemcgill Could you please take a look so we can merge this PR. Thanks! |
joemcgill
left a comment
There was a problem hiding this comment.
The updates look good to me. I've not gotten a chance to review the breaking change in WP yet, but thanks for reporting it.
Summary
Unit tests currently fail in
trunk, based on the 6.3 release from yesterday. There are two problems that lead to those failures:This PR brings parity with those changes:
thumbnailandnothumbonly when editing thumbnails separately is enabled (if using WP 6.3 or greater, per the new filter).Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.