Use dynamic version from `plugins.json` for manual workflow by mukeshpanchal27 · Pull Request #710 · WordPress/performance

mukeshpanchal27 · 2023-04-13T08:16:42Z

Summary

This PR mainly improves the manual workflow for standalone plugin releases.

Replaced the text input for the slug with a dropdown to select the specific modules so we don't get any human error if someone mistypes the slug.
Remove version input
How does the version work for automated and manual workflows?
- Automated workflow: It will read the plugins.json file and based on json config it setup the standalone plugin.
- Manual workflow: Based on the input slug the script will find the version for it, If the selected plugin slug is not present in plugins.json then trigger a failure and exit the workflow.

Also use test SVN credential so we can't release the plugin when doing testing.

I already open PR 10up/action-wordpress-plugin-deploy#122 that support the debug mode in deploy process. Once it will approve we can use DRY_RUN ENV variable for testing.

Fixes #703

Checklist

PR has either [Focus] or Infrastructure label.
PR has a [Type] label.
PR has a milestone or the no milestone label.

felixarntz

@mukeshpanchal27 Logic-wise this looks great. I have two comments for things to improve though, particularly the hard-coded options are not desirable as they are duplicated from what should be in plugins.json instead.

.github/workflows/deploy-standalone-plugins.yml

felixarntz

@mukeshpanchal27 Thanks, this looks great now!

One additional comment for consideration, though not necessarily a blocker.

.github/workflows/deploy-standalone-plugins.yml

joemcgill

This is working for me. 👍🏻

package.json

bin/plugin/commands/get-plugin-version.js

felixarntz · 2023-05-08T17:45:06Z

@mukeshpanchal27 Note that the DRY_RUN PR has now been merged upstream. So it would be great to incorporate that here.

Dismissing my review until the debugging code is updated

Co-authored-by: Colin Stewart <[email protected]>

mukeshpanchal27 · 2023-05-09T10:49:23Z

@mukeshpanchal27 Note that the DRY_RUN PR has now been merged upstream. So it would be great to incorporate that here.

@felixarntz The DRY_RUN PR has been merged into develop branch, not the stable branch, so we can't use it. If we have to use DRY_RUN then we have to use the develop branch, or we will use it once it is merged into the stable branch. cc. @joemcgill

felixarntz · 2023-05-09T17:37:00Z

Thanks @mukeshpanchal27, in that case let's do that separately. Could you please open a tracking issue for us to set up DRY_RUN in the future once it becomes available in a stable version of the action?

felixarntz

@mukeshpanchal27 Thanks, LGTM!

Just a reminder to update the below prior to merging.

.github/workflows/deploy-standalone-plugins.yml

mukeshpanchal27 · 2023-05-10T04:15:55Z

Thanks @mukeshpanchal27, in that case let's do that separately. Could you please open a tracking issue for us to set up DRY_RUN in the future once it becomes available in a stable version of the action?

@felixarntz, should we consider opening a separate issue to set up the DRY_RUN option? By doing so, the changes made will not be uploaded to SVN. This approach could be useful for testing the process before committing any actual changes. What are your thoughts on this?

felixarntz · 2023-05-10T13:58:19Z

@mukeshpanchal27 Yes that's what I meant. We could somehow configure it I think so that for example in pull requests it is always set to have DRY_RUN enabled.

joemcgill

The latest updates look right to me. Thanks @mukeshpanchal27!

mukeshpanchal27 added 2 commits April 13, 2023 11:47

Use dynamic version from plugins.json for manual workflow

c484e1e

Update SVN credentials

08ab6d3

mukeshpanchal27 added Infrastructure Issues for the overall performance plugin infrastructure Needs Review labels Apr 13, 2023

mukeshpanchal27 requested review from 10upsimon and joemcgill April 13, 2023 08:16

mukeshpanchal27 added no milestone PRs that do not have a defined milestone for release [Type] Enhancement A suggestion for improvement of an existing feature labels Apr 13, 2023

felixarntz requested changes Apr 17, 2023

View reviewed changes

.github/workflows/deploy-standalone-plugins.yml Outdated Show resolved Hide resolved

.github/workflows/deploy-standalone-plugins.yml Outdated Show resolved Hide resolved

.github/workflows/deploy-standalone-plugins.yml Outdated Show resolved Hide resolved

mukeshpanchal27 and others added 3 commits April 24, 2023 11:53

Address review feedback

6a6af58

Fix JS Lint

523a84e

Merge branch 'trunk' into fix/703-improve-manual-workflow

34d29a9

mukeshpanchal27 removed the Needs Review label Apr 24, 2023

mukeshpanchal27 marked this pull request as ready for review April 24, 2023 09:28

mukeshpanchal27 requested a review from JustinyAhin as a code owner April 24, 2023 09:28

mukeshpanchal27 requested review from costdev and felixarntz April 24, 2023 09:28

felixarntz approved these changes Apr 24, 2023

View reviewed changes

.github/workflows/deploy-standalone-plugins.yml Outdated Show resolved Hide resolved

joemcgill previously approved these changes Apr 24, 2023

View reviewed changes

package.json Outdated Show resolved Hide resolved

costdev reviewed May 4, 2023

View reviewed changes

bin/plugin/commands/get-plugin-version.js Outdated Show resolved Hide resolved

felixarntz added this to the 2.3.0 milestone May 8, 2023

felixarntz removed the no milestone PRs that do not have a defined milestone for release label May 8, 2023

mukeshpanchal27 and others added 4 commits May 9, 2023 15:43

Apply suggestions from code review

2b6ec16

Co-authored-by: Colin Stewart <[email protected]>

Remove get-plugin-version command

092a37f

Use regex to check the plugin version

4995c95

Merge branch 'trunk' into fix/703-improve-manual-workflow

ac522e2

mukeshpanchal27 requested review from costdev, felixarntz and joemcgill May 9, 2023 10:49

felixarntz approved these changes May 9, 2023

View reviewed changes

.github/workflows/deploy-standalone-plugins.yml Outdated Show resolved Hide resolved

mukeshpanchal27 commented May 10, 2023

View reviewed changes

.github/workflows/deploy-standalone-plugins.yml Outdated Show resolved Hide resolved

Apply suggestions from code review

52c6eb1

felixarntz mentioned this pull request May 10, 2023

Prepare 2.3.0 release #720

Closed

3 tasks

joemcgill approved these changes May 10, 2023

View reviewed changes

joemcgill merged commit 950c571 into trunk May 10, 2023

joemcgill deleted the fix/703-improve-manual-workflow branch May 10, 2023 22:40

mukeshpanchal27 mentioned this pull request May 23, 2023

Configure DRY_RUN to Github Action #734

Closed

Conversation

mukeshpanchal27 commented Apr 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

felixarntz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

felixarntz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

joemcgill left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

felixarntz commented May 8, 2023

Uh oh!

mukeshpanchal27 commented May 9, 2023

Uh oh!

felixarntz commented May 9, 2023

Uh oh!

felixarntz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mukeshpanchal27 commented May 10, 2023

Uh oh!

felixarntz commented May 10, 2023

Uh oh!

joemcgill left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mukeshpanchal27 commented Apr 13, 2023 •

edited

Loading