Change module slug/directory from dominant-color to dominant-color-images#708
Merged
mukeshpanchal27 merged 5 commits intotrunkfrom Apr 10, 2023
Merged
Change module slug/directory from dominant-color to dominant-color-images#708mukeshpanchal27 merged 5 commits intotrunkfrom
dominant-color to dominant-color-images#708mukeshpanchal27 merged 5 commits intotrunkfrom
Conversation
felixarntz
added
[Type] Documentation
felixarntz
requested review from
JustinyAhin,
adamsilverstein,
getsource,
pbearne and
spacedmonkey
as code owners
Member
Author
|
cc @mukeshpanchal27 @10upsimon Let's aim to get this merged for the 2.2.0 release as well so that it goes out together with #705. This means we should do some extra testing in this release that, when using an older plugin version and we have the module active it remains active after the update to this release. I'll be OOO next week, but please feel free to take over this PR, should it require any updates I don't see today. |
3 tasks
tests/modules/images/dominant-color-images/dominant-color-image-editor-gd-test.php
Outdated
Show resolved
Hide resolved
mukeshpanchal27
approved these changes
Apr 10, 2023
Member
mukeshpanchal27
left a comment
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thanks @felixarntz, The changes look good to me. In 68fa2df, I have updated two @group annotation instances.
10upsimon
approved these changes
Apr 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #705.
Related to #640.
Relevant technical choices
Dominant ColorandFetchprioritymodules for their standalone plugins #704 (review).readme.txtare not updated as part of this PR, as those will be updated automatically as part of the release process, except fordefault-enabled-modules.php, which is used by unit tests and needed to be updated so that they still work correctly.Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.