Generator meta tag for WebP Uploads standalone plugin #696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukeshpanchal27
added
[Type] Enhancement
felixarntz
approved these changes
Apr 4, 2023
Member
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
Thanks @mukeshpanchal27! This is almost good to go, a few small suggestions on the output to standardize it more with e.g. how the PL plugin and WP core output it.
Co-authored-by: Felix Arntz <[email protected]>
joemcgill
approved these changes
Apr 4, 2023
Member
joemcgill
left a comment
joemcgill
left a comment
There was a problem hiding this comment.
This looks good to me. I think we may want to consider a future enhancement where we can move a lot of the shared library code to a central place that gets built into the individual plugins. I'll create a new issue for that after we finish this process.
felixarntz
approved these changes
Apr 4, 2023
Member
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
@mukeshpanchal27 LGTM! One tiny non-blocking thing, I think I can quickly fix that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #692
This PR adds a generator meta tag for the WebP Uploads module. We can use the same function for other modules once the WebP Uploads plugin is released.
Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.