Skip to content

Conversation

@mukeshpanchal27
Copy link
Member

Summary

Fixes #673

Relevant technical choices

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@mukeshpanchal27 mukeshpanchal27 added [Type] Bug An existing feature is broken Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release labels Mar 20, 2023
@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review March 20, 2023 11:28
Copy link
Contributor

@10upsimon 10upsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as this worked for me. I cloned to a dir named perf-test and config path was correct as this snippet from my terminal output shows:

Configuration: /var/www/html/wp-content/plugins/perf-test/phpunit.xml.dist

Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@felixarntz felixarntz merged commit a867759 into trunk Mar 20, 2023
@felixarntz felixarntz deleted the fix/673-dynamic-plugin-path branch March 20, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release [Type] Bug An existing feature is broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix running tests not working unless the repository is cloned to a performance directory

5 participants