Fix invalid docs and return types as highlighted by static analysis#645
Merged
mukeshpanchal27 merged 6 commits intotrunkfrom Feb 7, 2023
Merged
Fix invalid docs and return types as highlighted by static analysis#645mukeshpanchal27 merged 6 commits intotrunkfrom
mukeshpanchal27 merged 6 commits intotrunkfrom
Conversation
kt-12
requested review from
JustinyAhin,
OllieJones and
felixarntz
as code owners
kt-12
added
[Type] Bug
felixarntz
added
[Focus] Database
and removed
no milestone
felixarntz
changed the title
Member
|
@aristath This fixes a few minor things in the SQLite module, so I wanted to make sure you see this. Right now we're in a bit of an unfortunate situation of having the code duplicated, so can you make sure to address this in your plugin as well? Should be a quick fix. (The return types need to align with the parent classes, for example.) |
Member
|
@mukeshpanchal27 Can you give this a 2nd review and approval please? |
mukeshpanchal27
approved these changes
Feb 7, 2023
Member
mukeshpanchal27
left a comment
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thanks @kt-12, The changes look good to me!
aristath
added a commit
to WordPress/sqlite-database-integration
that referenced
this pull request
Feb 7, 2023
Member
|
Backported to the standalone plugin as well 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #622
Fix issues with doc type and return that was throwing error in static test.
Relevant technical choices
Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.