Enhance object-cache.php drop-in interoperability with other plugins#616
Merged
felixarntz merged 2 commits intotrunkfrom Jan 9, 2023
Merged
Enhance object-cache.php drop-in interoperability with other plugins#616felixarntz merged 2 commits intotrunkfrom
felixarntz merged 2 commits intotrunkfrom
Conversation
…ve testing via mock filesystem.
felixarntz
added
[Type] Bug
felixarntz
requested review from
adamsilverstein,
jjgrainger and
mukeshpanchal27
tillkruss
reviewed
Dec 23, 2022
load.php
Outdated
| // https://github.com/WordPress/performance/issues/612). | ||
| // In that case we can simply delete the main file since it is | ||
| // already backed up. | ||
| if ( $wp_filesystem->exists( WP_CONTENT_DIR . '/object-cache-plst-orig.php' ) ) { |
Member
Author
There was a problem hiding this comment.
Just a shorthand for "Performance Lab Server Timing" to make the file name more "unique" (e.g. in case another plugin would already do something similar using -orig suffix).
Member
mukeshpanchal27
left a comment
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thanks @felixarntz Overall looks solid to me. Left some feedbacks.
jjgrainger
approved these changes
Jan 5, 2023
Contributor
jjgrainger
left a comment
jjgrainger
left a comment
There was a problem hiding this comment.
Thanks @felixarntz changes look good
mukeshpanchal27
approved these changes
Jan 6, 2023
Member
mukeshpanchal27
left a comment
mukeshpanchal27
left a comment
There was a problem hiding this comment.
Thanks @felixarntz, LGTM!
merkys7
approved these changes
Jan 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #612
Relevant technical choices
perflab_maybe_set_object_cache_dropin(), which previously was basically untested. It does so via a new (for now very basic) mock filesystem class.Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.