Add checkbox to Settings > Media to control whether to generate JPEG in addition to WebP by mehulkaklotar · Pull Request #537 · WordPress/performance

mehulkaklotar · 2022-09-19T07:21:41Z

Summary

This PR is dependent on the issue #524 and PR #527

PR introduces

WordPress setting generate_webp_and_jpeg -> boolean value
Changes default filter output for webp_uploads_upload_image_mime_transforms to image/jpeg and image/webp if the generate_webp_and_jpeg is true

Remaining work(After #524 is merged)

Add unit tests around new WP Settings and their use with filter
Changes if needed any from the dependent PR Generate only WebP images by default for JPEG and WebP uploads #527

Fixes #525

Relevant technical choices

Checklist

PR has either [Focus] or Infrastructure label.
PR has a [Type] label.
PR has a milestone or the no milestone label.

…Uploads section

mehulkaklotar

@mukeshpanchal27 Changes looks good here. We should add some tests for the new setting.

modules/images/webp-uploads/helper.php

felixarntz

@mehulkaklotar This is on a good path, some quirks to address though.

modules/images/webp-uploads/helper.php

modules/images/webp-uploads/image-edit.php

modules/images/webp-uploads/load.php

tests/modules/images/webp-uploads/load-tests.php

modules/images/webp-uploads/helper.php

modules/images/webp-uploads/load.php

felixarntz

@mehulkaklotar One more thing: Please make sure to delete the new option in uninstall.php.

…_jpeg

…from suggestions

… suggestions

felixarntz

@mehulkaklotar This is almost good to go now. Left mostly minor suggestions, so there are two quirks (one little tricky) to still address.

modules/images/webp-uploads/helper.php

modules/images/webp-uploads/settings.php

Co-authored-by: Felix Arntz <[email protected]>

tests/modules/images/webp-uploads/helper-tests.php

tests/modules/images/webp-uploads/load-tests.php

felixarntz

@mukeshpanchal27 @mehulkaklotar One small optimization recommendation here, but other than that this is good to go.

modules/images/webp-uploads/settings.php

Co-authored-by: Felix Arntz <[email protected]>

felixarntz

Thanks @mukeshpanchal27, LGTM!

mehulkaklotar added 2 commits September 19, 2022 12:49

new setting added for generating webp and jpeg in Settings > Media > …

1780c65

…Uploads section

new setting used when true for generating webp and jpeg

952a40a

mehulkaklotar added [Type] Enhancement A suggestion for improvement of an existing feature [Focus] Images [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) labels Sep 19, 2022

mehulkaklotar added this to the 1.6.0 milestone Sep 19, 2022

mehulkaklotar assigned mehulkaklotar and unassigned mehulkaklotar Sep 19, 2022

mehulkaklotar and others added 10 commits September 21, 2022 20:13

Merge branch 'trunk' into enhancement/525-checkbox-multi-mime-setting

7b3e221

Merge branch 'trunk' into enhancement/525-checkbox-multi-mime-setting

cd79323

Merge branch 'trunk' into enhancement/525-checkbox-multi-mime-setting

6094407

Set default value for option

cd96030

Update markup and remove the return in function

1f3d1cc

Set default value and code from parent PR

49cd8f6

Unset default value for option

a328153

Unset default value for option

b6a6531

Add webp_uploads_check_multi_mime_support()

4570b8d

Update image-edit.php

9d8a992

mehulkaklotar commented Oct 5, 2022

View reviewed changes

modules/images/webp-uploads/helper.php Outdated Show resolved Hide resolved

modules/images/webp-uploads/helper.php Outdated Show resolved Hide resolved

Unit test for new setting

2c73233

mehulkaklotar marked this pull request as ready for review October 5, 2022 11:20

mehulkaklotar requested review from adamsilverstein, felixarntz and mitogh as code owners October 5, 2022 11:20

Merge branch 'trunk' into enhancement/525-checkbox-multi-mime-setting

89cc855

mukeshpanchal27 requested review from jjgrainger and mukeshpanchal27 October 5, 2022 11:40

felixarntz requested changes Oct 5, 2022

View reviewed changes

felixarntz changed the title ~~Enhancement/525 checkbox multi mime setting~~ Add checkbox to Settings > Media to control whether to generate JPEG in addition to WebP Oct 5, 2022

felixarntz reviewed Oct 5, 2022

View reviewed changes

mehulkaklotar added 4 commits October 5, 2022 23:59

settings.php file added for the new setting perflab_generate_webp_and…

112e259

…_jpeg

new setting perflab_generate_webp_and_jpeg used and filters reverted …

ce3a8b2

…from suggestions

new setting perflab_generate_webp_and_jpeg tests added and moved from…

35b303a

… suggestions

new setting perflab_generate_webp_and_jpeg deleted when uninstalled

9a71553

mehulkaklotar requested a review from felixarntz October 5, 2022 18:40

felixarntz reviewed Oct 6, 2022

View reviewed changes

mukeshpanchal27 and others added 8 commits October 6, 2022 09:35

Update document

23b8102

Co-authored-by: Felix Arntz <[email protected]>

Update document

1cd10bc

Co-authored-by: Felix Arntz <[email protected]>

Update modules/images/webp-uploads/settings.php

f892ddb

Co-authored-by: Felix Arntz <[email protected]>

Update document

f7c3a2a

Co-authored-by: Felix Arntz <[email protected]>

Update document

02aaa7d

Co-authored-by: Felix Arntz <[email protected]>

Add $args in register_setting

0c3a321

Co-authored-by: Felix Arntz <[email protected]>

Fix PHPCS and remove doc

c7b7575

Update structure and add css

ab65615

mukeshpanchal27 requested a review from felixarntz October 6, 2022 06:59

mukeshpanchal27 added 2 commits October 6, 2022 12:37

Update style

691f5a1

Revert some changes

8a00c25

mehulkaklotar commented Oct 6, 2022

View reviewed changes

tests/modules/images/webp-uploads/helper-tests.php Outdated Show resolved Hide resolved

Update tests/modules/images/webp-uploads/helper-tests.php

522dea3

mehulkaklotar commented Oct 6, 2022

View reviewed changes

tests/modules/images/webp-uploads/helper-tests.php Outdated Show resolved Hide resolved

tests/modules/images/webp-uploads/load-tests.php Outdated Show resolved Hide resolved

mehulkaklotar added 2 commits October 6, 2022 13:39

Update tests/modules/images/webp-uploads/helper-tests.php

d2a3a13

Update tests/modules/images/webp-uploads/load-tests.php

c80ca0f

felixarntz reviewed Oct 6, 2022

View reviewed changes

modules/images/webp-uploads/settings.php Outdated Show resolved Hide resolved

modules/images/webp-uploads/settings.php Outdated Show resolved Hide resolved

mukeshpanchal27 and others added 2 commits October 7, 2022 10:21

Update add_action

25858c9

Co-authored-by: Felix Arntz <[email protected]>

Remove global and condition

90cac1f

mukeshpanchal27 approved these changes Oct 7, 2022

View reviewed changes

mukeshpanchal27 requested a review from felixarntz October 7, 2022 05:07

felixarntz approved these changes Oct 7, 2022

View reviewed changes

felixarntz merged commit 55213ba into trunk Oct 7, 2022

felixarntz deleted the enhancement/525-checkbox-multi-mime-setting branch October 7, 2022 20:13

Conversation

mehulkaklotar commented Sep 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Relevant technical choices

Checklist

Uh oh!

mehulkaklotar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

felixarntz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

felixarntz left a comment

Choose a reason for hiding this comment

Uh oh!

felixarntz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

felixarntz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

felixarntz left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mehulkaklotar commented Sep 19, 2022 •

edited

Loading