Fix REST API support for plain permalinks.#457
Merged
felixarntz merged 1 commit intotrunkfrom Aug 8, 2022
Merged
Conversation
peterwilsoncc
added
[Type] Bug
peterwilsoncc
requested review from
adamsilverstein,
felixarntz and
mitogh
as code owners
mxbclang
removed
the
no milestone
jjgrainger
approved these changes
Jul 28, 2022
Contributor
jjgrainger
left a comment
jjgrainger
left a comment
There was a problem hiding this comment.
Thanks @peterwilsoncc looks good
felixarntz
approved these changes
Aug 8, 2022
Member
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
@peterwilsoncc Great catch, thanks!
swissspidy
added
[Plugin] Modern Image Formats
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensure the WebP fallback JavaScript works with sites using plain permalinks.
Fixes #456.
Relevant technical choices
I decided to copy the approach used in the
@wordpress/apiFetchrootUrlmiddleware that handles this exact issue. It seems to work.Ensures that the querystring does not have a double
?if the site is configured using plain permalinks.Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.