Skip to content

Dominant Color: GIF images always being flagged as having transparency. #419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
felixarntz merged 3 commits into from
Jul 14, 2022
Merged

Dominant Color: GIF images always being flagged as having transparency. #419

felixarntz merged 3 commits into from
Jul 14, 2022

Conversation

@spacedmonkey
Copy link
Member

@spacedmonkey spacedmonkey commented Jul 6, 2022

Summary

Turns out the fixture data was wrong and encoding incorrectly.
Fixes #405

Relevant technical choices

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@spacedmonkey spacedmonkey added [Type] Bug An existing feature is broken [Focus] Images [Plugin] Image Placeholders Issues for the Image Placeholders plugin (formerly Dominant Color Images) labels Jul 6, 2022
@spacedmonkey spacedmonkey added this to the 1.3.0 milestone Jul 6, 2022
@spacedmonkey spacedmonkey requested a review from pbearne as a code owner July 6, 2022 15:57
@spacedmonkey spacedmonkey self-assigned this Jul 6, 2022
pbearne
pbearne approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@pbearne pbearne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well spotted

@spacedmonkey
Copy link
Member Author

spacedmonkey commented Jul 14, 2022

@adamsilverstein @felixarntz Can I get an approval here. This is a fix for unit tests.

adamsilverstein
adamsilverstein approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@adamsilverstein adamsilverstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

felixarntz
felixarntz approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@felixarntz felixarntz added the no milestone PRs that do not have a defined milestone for release label Jul 14, 2022
@felixarntz felixarntz removed this from the 1.3.0 milestone Jul 14, 2022
@felixarntz felixarntz merged commit 3171285 into trunk Jul 14, 2022
@felixarntz felixarntz deleted the fix/alpha branch July 14, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pbearne pbearne pbearne approved these changes

@adamsilverstein adamsilverstein adamsilverstein approved these changes

@felixarntz felixarntz felixarntz approved these changes

Assignees

@spacedmonkey spacedmonkey

Labels

no milestone PRs that do not have a defined milestone for release [Plugin] Image Placeholders Issues for the Image Placeholders plugin (formerly Dominant Color Images) [Type] Bug An existing feature is broken

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dominant Color: GIF images always being flagged as having transparency.

5 participants

@spacedmonkey @pbearne @adamsilverstein @felixarntz