Fix dominant color upload process to not override potential third-party editors#401
Merged
spacedmonkey merged 4 commits intotrunkfrom Jul 6, 2022
Merged
Fix dominant color upload process to not override potential third-party editors#401spacedmonkey merged 4 commits intotrunkfrom
spacedmonkey merged 4 commits intotrunkfrom
Conversation
spacedmonkey
added
[Type] Bug
felixarntz
changed the title
felixarntz
reviewed
Jun 29, 2022
Member
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
@spacedmonkey Thanks, production code looks good, just one tiny nit-pick.
There are unit test failures though, could you check and address those?
Co-authored-by: Felix Arntz <[email protected]>
Member
Author
Tests are failing because #405. This is because ImageMagik is flagging all gifs as transparent. I have put a workaround in for now and we can tackle that issue there. |
adamsilverstein
approved these changes
Jul 6, 2022
Member
adamsilverstein
left a comment
adamsilverstein
left a comment
There was a problem hiding this comment.
Code looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace editor in a cleaner way.
Fixes #374
Relevant technical choices
Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.