Correct label for persistent object cache Site Health check#329
Merged
felixarntz merged 2 commits intoWordPress:trunkfrom May 10, 2022
mukeshpanchal27:fix/label-persistent-object-cache
Merged
Correct label for persistent object cache Site Health check#329felixarntz merged 2 commits intoWordPress:trunkfrom mukeshpanchal27:fix/label-persistent-object-cache
felixarntz merged 2 commits intoWordPress:trunkfrom
mukeshpanchal27:fix/label-persistent-object-cache
Conversation
mxbclang
added
[Type] Bug
tillkruss
approved these changes
May 9, 2022
tillkruss
added
[Type] Bug
spacedmonkey
approved these changes
May 9, 2022
felixarntz
reviewed
May 9, 2022
Member
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
@mukeshpanchal27 One small thing to address here, other than that lgtm.
modules/object-cache/persistent-object-cache-health-check/load.php
Outdated
Show resolved
Hide resolved
3 tasks
felixarntz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #328
Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.