Skip to content

Define module owners and add them to CODEOWNERS file #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
felixarntz merged 3 commits into from
May 3, 2022
Merged

Define module owners and add them to CODEOWNERS file #317

felixarntz merged 3 commits into from
May 3, 2022

Conversation

@felixarntz
Copy link
Member

@felixarntz felixarntz commented Apr 25, 2022 •
edited
Loading

Summary

Fixes #310

Relevant technical choices

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@felixarntz felixarntz added [Type] Documentation Documentation to be added or enhanced Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release Needs Review labels Apr 25, 2022
@felixarntz felixarntz requested a review from JustinyAhin as a code owner April 25, 2022 22:35
@felixarntz felixarntz mentioned this pull request Apr 25, 2022
Closed
@kirtangajjar
Copy link
Member

kirtangajjar commented Apr 26, 2022

@felixarntz I would like to recommend adding @mitogh to webp support section. He has made significant contributions during review and other processes as well. Apart from that, I'm not too sure of my availability so I think having him as an additional POC would be great.

@felixarntz
Copy link
Member Author

felixarntz commented Apr 26, 2022

Per DM conversation with @mitogh, I've added him to both WebP-related modules as an additional owner. 🎉

@felixarntz felixarntz requested a review from mitogh April 26, 2022 22:59
@felixarntz felixarntz merged commit 3db7042 into trunk May 3, 2022
@felixarntz felixarntz deleted the add/module-codeowners branch May 3, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spacedmonkey spacedmonkey spacedmonkey approved these changes

@tillkruss tillkruss tillkruss approved these changes

@manuelRod manuelRod manuelRod approved these changes

@adamsilverstein adamsilverstein adamsilverstein approved these changes

@mitogh mitogh mitogh approved these changes

@kirtangajjar kirtangajjar kirtangajjar approved these changes

@JustinyAhin JustinyAhin Awaiting requested review from JustinyAhin

@mxbclang mxbclang Awaiting requested review from mxbclang

Assignees

No one assigned

Labels

Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release [Type] Documentation Documentation to be added or enhanced

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Define owners for each module

8 participants

@felixarntz @kirtangajjar @spacedmonkey @tillkruss @manuelRod @adamsilverstein @mitogh