Replace the featured image with WebP version when available#316
Merged
felixarntz merged 2 commits intotrunkfrom May 2, 2022
Merged
Replace the featured image with WebP version when available#316felixarntz merged 2 commits intotrunkfrom
felixarntz merged 2 commits intotrunkfrom
Conversation
When a modern format is available to render the featured image make sure that the replacement image uses the same logic used to replace the images in the content in order to be consistent with the rest of rendered format. Fixes #288
|
Thanks for the PR @mitogh! |
adamsilverstein
approved these changes
Apr 29, 2022
Member
adamsilverstein
left a comment
There was a problem hiding this comment.
Looks good, nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a modern format is available to render the featured image make sure that the replacement image uses the same logic used to replace the images in the content in order to be consistent
with the rest of rendered format.
Fixes #288
Relevant technical choices
Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.