Ensure default modules are loaded regardless of setting registration#248
Merged
felixarntz merged 1 commit intorelease/1.0.0-beta.3from Mar 22, 2022
Merged
Ensure default modules are loaded regardless of setting registration#248felixarntz merged 1 commit intorelease/1.0.0-beta.3from
felixarntz merged 1 commit intorelease/1.0.0-beta.3from
Conversation
…ting registration.
felixarntz
added
[Type] Bug
felixarntz
requested review from
JustinyAhin,
adamsilverstein,
kirtangajjar and
mitogh
felixarntz
changed the title
Member
Author
|
I've tested this PR on a fresh site and can confirm that all non-experimental modules are now loaded there right away (i.e. without updating settings under Settings > Performance), when before they weren't:
|
ThierryA
approved these changes
Mar 22, 2022
kirtangajjar
approved these changes
Mar 22, 2022
eugene-manuilov
approved these changes
Mar 22, 2022
jjgrainger
approved these changes
Mar 22, 2022
This was referenced Mar 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #247
Relevant technical choices
get_option()inperflab_get_module_settings(), it is ensured the default value is always used, even when the setting is not registered yet.perflab_get_module_settings()function to get the setting value, this ensures the default is also taken into consideration early (e.g. when the active modules are being loaded).get_option()directly.Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.