Fix invalid Server-Timing logic for database query timing whe `$wpdb->queries` is `null` due to no query having been done yet by Copilot · Pull Request #2346 · WordPress/performance

Copilot · 2026-01-14T01:44:10Z

Understand the issue: $wpdb->queries can be null when no queries have run yet, which is a valid state
Fix before-template-db-queries metric to handle null case by setting metric to 0.0
Fix template-db-queries metric to handle null case by setting metric to 0.0
Separate null check from array type check to only error on truly malformed data
Ensure $GLOBALS['perflab_query_time_before_template'] is set even when queries is null
Avoid negative query times by setting template metric to 0.0 when no queries exist
Commit the changes

Original prompt

The logoc here appears to be invalid:

performance/plugins/performance-lab/includes/server-timing/defaults.php

Lines 50 to 72 in b4f9898

// This should never happen, but some odd database implementations may be doing it wrong.

if ( ! isset( $GLOBALS['wpdb']->queries ) || ! is_array( $GLOBALS['wpdb']->queries ) ) {

wp_trigger_error(

$current_function,

esc_html(

sprintf(

/* translators: 1: before-template-db-queries, 2: $wpdb->queries */

__( 'Unable to compute server timing for "%1$s" because %2$s is not an array.', 'performance-lab' ),

'before-template-db-queries',

'$wpdb->queries'

)

)

);

return;

}

/**

* Query times.

*

* @var float[] $query_times

*/

$query_times = array();

foreach ( $GLOBALS['wpdb']->queries as $query ) {

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

westonruter · 2026-01-14T01:46:54Z

@copilot I didn't finish. I was going to say that it is invalid because before the first query is run, the $wpdb->queries variable will be null. It will only become an array once the first query has been made. Update the logic to account for the null case.

Co-authored-by: westonruter <[email protected]>

Copilot · 2026-01-14T01:52:07Z

@copilot I didnt finish. I was gokng to say that it is invalid because before the first query is run, the $wpdb->queries variable will be null. It will only become an array once the first query has ...

Fixed in d037da9. The logic now handles the null case correctly:

When $wpdb->queries is null (no queries run yet), before-template-db-queries returns 0.0
When $wpdb->queries is null, template-db-queries calculates the difference correctly
Only triggers an error if $wpdb->queries is set but not an array (truly malformed)

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

https://api.github.com/repos/PHPCSStandards/PHP_CodeSniffer/zipball/0ca86845ce43291e8f5692c7356fccf3bcf02bf4
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/gO9XbJ /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/PHPCSStandards/composer-installer/zipball/845eb62303d2ca9b289ef216356568ccc075ffd1
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/gO9XbJ /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/doctrine/instantiator/zipball/0a0fa9780f5d4e507415a065172d26a98d02047b
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/gO9XbJ /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/myclabs/DeepCopy/zipball/1720ddd719e16cf0db4eb1c6eca108031636d46c
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/gO9XbJ /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/phar-io/manifest/zipball/54750ef60c58e43759730615a392c31c80e23176
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/gO9XbJ /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/phar-io/version/zipball/4f7fd7836c6f332bb2933569e566a0d6c4cbed74
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/gO9XbJ /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/phpstan/extension-installer/zipball/85e90b3942d06b2326fba0403ec24fe912372936
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/gO9XbJ /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/phpstan/php-8-stubs/zipball/2da4cdab8ac153926628877fbacebc80ba175b7c
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/gO9XbJ /usr/bin/composer install --no-interaction (http block)
https://api.github.com/repos/phpstan/phpstan/zipball/3a6e423c076ab39dfedc307e2ac627ef579db162
- Triggering command: /usr/bin/php8.3 /usr/bin/php8.3 -n -c /tmp/gO9XbJ /usr/bin/composer install --no-interaction (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

westonruter · 2026-01-14T02:07:03Z

plugins/performance-lab/includes/server-timing/defaults.php

+						// If no queries have been run yet, $wpdb->queries will be null, which is valid (0 queries).
+						if ( ! isset( $GLOBALS['wpdb']->queries ) ) {
+							$metric->set_value( 0.0 );
+							return;


@copilot problem: this is isn't setting the $GLOBALS['perflab_query_time_before_template'] global

Fixed in 112bdf3. The global $GLOBALS['perflab_query_time_before_template'] is now set to 0.0 when $wpdb->queries is null, ensuring the template-db-queries metric can calculate correctly later.

Co-authored-by: westonruter <[email protected]>

westonruter · 2026-01-14T02:08:44Z

plugins/performance-lab/includes/server-timing/defaults.php

+							// If no queries have been run yet, $wpdb->queries will be null, which is valid (0 queries).
+							// In this case, template query time is just negative of before-template time.
+							if ( ! isset( $GLOBALS['wpdb']->queries ) ) {
+								$metric->set_value( ( 0.0 - $GLOBALS['perflab_query_time_before_template'] ) * 1000.0 );


@copilot but a negative query time doesn't really make sense, does it?

You're right. Fixed in 04afa03. When $wpdb->queries is null, it means no queries have been executed, so the template query time should be 0.0 (not a negative value).

Co-authored-by: westonruter <[email protected]>

westonruter · 2026-01-14T02:14:50Z

Disclosure: this bug was brought to my attention by @afragen but I'm on my phone right now, so I tried using Copilot to make the necessary changes.

codecov · 2026-01-14T02:23:18Z

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.20%. Comparing base (c9720dc) to head (45ea829).
⚠️ Report is 20 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...erformance-lab/includes/server-timing/defaults.php	0.00%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##            trunk    #2346      +/-   ##
==========================================
- Coverage   69.21%   69.20%   -0.02%     
==========================================
  Files          90       90              
  Lines        7703     7705       +2     
==========================================
  Hits         5332     5332              
- Misses       2371     2373       +2

Flag	Coverage Δ
multisite	`69.20% <0.00%> (-0.02%)`	⬇️
single	`35.40% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2026-01-14T23:05:07Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @Copilot.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: Copilot.

Co-authored-by: westonruter <[email protected]>
Co-authored-by: b1ink0 <[email protected]>
Co-authored-by: afragen <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

westonruter · 2026-01-14T23:05:41Z

Build for testing: performance-lab.zip

afragen · 2026-01-15T18:23:46Z

Build for testing: performance-lab.zip

This has worked for me. There are no further associated error log messages.

Initial plan

7924697

Copilot AI assigned Copilot and westonruter Jan 14, 2026

Copilot started work on behalf of westonruter January 14, 2026 01:44 View session

Copilot AI requested a review from westonruter January 14, 2026 01:45

Copilot stopped work on behalf of westonruter due to an error January 14, 2026 01:45
The session was cancelled by the user.

Copilot started work on behalf of westonruter January 14, 2026 01:47 View session

Fix invalid logic for null wpdb->queries in server timing metrics

d037da9

Co-authored-by: westonruter <[email protected]>

Copilot AI changed the title ~~[WIP] Fix invalid logo URL in server timing settings~~ Fix invalid logic for null wpdb->queries in server timing metrics Jan 14, 2026

Copilot finished work on behalf of westonruter January 14, 2026 01:52

westonruter reviewed Jan 14, 2026

View reviewed changes

Copilot started work on behalf of westonruter January 14, 2026 02:07 View session

Set perflab_query_time_before_template global when queries is null

112bdf3

Co-authored-by: westonruter <[email protected]>

westonruter reviewed Jan 14, 2026

View reviewed changes

Copilot AI requested a review from westonruter January 14, 2026 02:09

Copilot finished work on behalf of westonruter January 14, 2026 02:09

Copilot started work on behalf of westonruter January 14, 2026 02:09 View session

Fix template-db-queries to return 0 when queries is null

04afa03

Co-authored-by: westonruter <[email protected]>

Copilot finished work on behalf of westonruter January 14, 2026 02:11

westonruter added [Type] Bug An existing feature is broken [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only labels Jan 14, 2026

westonruter added this to the performance-lab n.e.x.t milestone Jan 14, 2026

Reduce redundancy

45ea829

westonruter marked this pull request as ready for review January 14, 2026 23:04

westonruter requested review from felixarntz and mukeshpanchal27 as code owners January 14, 2026 23:04

westonruter changed the title ~~Fix invalid logic for null wpdb->queries in server timing metrics~~ Fix invalid Server-Timing logic for database query timing whe $wpdb->queries is null due to no query having been done yet Jan 14, 2026

westonruter added this to WP Performance Ongoing Jan 14, 2026

github-project-automation bot moved this to Not Started/Backlog 📆 in WP Performance Ongoing Jan 14, 2026

westonruter moved this from Not Started/Backlog 📆 to Code Review 👀 in WP Performance Ongoing Jan 14, 2026

westonruter approved these changes Jan 14, 2026

View reviewed changes

westonruter requested a review from b1ink0 January 15, 2026 18:47

westonruter approved these changes Jan 15, 2026

View reviewed changes

b1ink0 approved these changes Jan 15, 2026

View reviewed changes

westonruter merged commit 7becbba into trunk Jan 15, 2026
45 checks passed

github-project-automation bot moved this from Code Review 👀 to Done 😃 in WP Performance Ongoing Jan 15, 2026

westonruter deleted the copilot/fix-invalid-logo-url branch January 15, 2026 19:10

westonruter mentioned this pull request Jan 15, 2026

Add GitHub Copilot instructions for repository #2352

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix invalid Server-Timing logic for database query timing whe `$wpdb->queries` is `null` due to no query having been done yet#2346

Fix invalid Server-Timing logic for database query timing whe `$wpdb->queries` is `null` due to no query having been done yet#2346
westonruter merged 5 commits intotrunkfrom
copilot/fix-invalid-logo-url

Copilot AI commented Jan 14, 2026 •

edited

Loading

Uh oh!

westonruter commented Jan 14, 2026 •

edited

Loading

Uh oh!

Copilot AI commented Jan 14, 2026 •

edited

Loading

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

westonruter Jan 14, 2026

Uh oh!

Copilot AI Jan 14, 2026

Uh oh!

westonruter Jan 14, 2026

Uh oh!

Copilot AI Jan 14, 2026

Uh oh!

westonruter commented Jan 14, 2026

Uh oh!

codecov bot commented Jan 14, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 14, 2026 •

edited

Loading

Uh oh!

westonruter commented Jan 14, 2026

Uh oh!

afragen commented Jan 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	// This should never happen, but some odd database implementations may be doing it wrong.
	if ( ! isset( $GLOBALS['wpdb']->queries ) \|\| ! is_array( $GLOBALS['wpdb']->queries ) ) {
	wp_trigger_error(
	$current_function,
	esc_html(
	sprintf(
	/* translators: 1: before-template-db-queries, 2: $wpdb->queries */
	__( 'Unable to compute server timing for "%1$s" because %2$s is not an array.', 'performance-lab' ),
	'before-template-db-queries',
	'$wpdb->queries'
	)
	)
	);
	return;
	}

	/**
	* Query times.
	*
	* @var float[] $query_times
	*/
	$query_times = array();
	foreach ( $GLOBALS['wpdb']->queries as $query ) {

Conversation

Copilot AI commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

westonruter commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

westonruter Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

westonruter Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

westonruter commented Jan 14, 2026

Uh oh!

codecov bot commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Unlinked Accounts

Uh oh!

westonruter commented Jan 14, 2026

Uh oh!

afragen commented Jan 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Jan 14, 2026 •

edited

Loading

westonruter commented Jan 14, 2026 •

edited

Loading

Copilot AI commented Jan 14, 2026 •

edited

Loading

codecov bot commented Jan 14, 2026 •

edited

Loading

github-actions bot commented Jan 14, 2026 •

edited

Loading