Use .gitattributes instead of .distignore to better support ZIP creation#223
Merged
felixarntz merged 5 commits intoWordPress:trunkfrom Mar 10, 2022
Merged
Conversation
mitogh
added
the
[Type] Enhancement
mitogh
approved these changes
Mar 9, 2022
Member
mitogh
left a comment
mitogh
left a comment
There was a problem hiding this comment.
Thanks, this looks good and works as expected, after running the git archive command.
mitogh
added
the
Infrastructure
Member
Author
|
Thanks, @mitogh for looking into this. I think this PR needs one more approval so can you please add reviewers? |
Member
|
That's correct @thelovekesh let's wait on someone else to take a look at this and give us some feedback before we can move forward with the merge, otherwise, feel free to mention in our next call next Tuesday (if you are unable to make it) I would make sure to mention about this. Great work and thank you for your collaboration to the project. |
felixarntz
approved these changes
Mar 10, 2022
Member
felixarntz
left a comment
felixarntz
left a comment
There was a problem hiding this comment.
Great work @thelovekesh - thank you for the PR!
felixarntz
changed the title
.distignore to .gitattributes.gitattributes instead of .distignore to better support ZIP creation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #217
Relevant technical choices
.disignoreto.gitattributesREADMEfile asexport-ignorein.gitattributesChecklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.