Replace unreliable activation hook with default value for enabled modules#222
Merged
felixarntz merged 5 commits intotrunkfrom Mar 14, 2022
Merged
Replace unreliable activation hook with default value for enabled modules#222felixarntz merged 5 commits intotrunkfrom
felixarntz merged 5 commits intotrunkfrom
Conversation
added 3 commits
March 8, 2022 14:31
…iable on environments like multisite as well.
…-modules.php file.
…ault enabled modules.
|
Tested scenarios,
All scenarios now working as expected with default values as they should be. |
gagan0123
approved these changes
Mar 9, 2022
mitogh
reviewed
Mar 9, 2022
mitogh
approved these changes
Mar 9, 2022
JustinyAhin
approved these changes
Mar 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #218
Fixes #219
Relevant technical choices
default-enabled-modules.phpwhich, similarly to the existingmodule-i18n.phpfile, can be automatically generated and maintained.Checklist
[Focus]orInfrastructurelabel.[Type]label.no milestonelabel.